Attention is currently required from: Jg Daolongzhu, Hung-Te Lin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51024 )
Change subject: WIP: soc/mediatek/mt8192: adjust i2c tLOW,tSU,STO ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51024/comment/b0ce01ec_61ee6ee8 PS5, Line 2: jg_daolongzhu Please use *Jg Daolongzhu*.
https://review.coreboot.org/c/coreboot/+/51024/comment/a35be4d8_b234d7fc PS5, Line 7: tLOW,tSU,STO Please add a space after the comma.
https://review.coreboot.org/c/coreboot/+/51024/comment/40cd4d5f_c84f77e7 PS5, Line 8: Please describe the problem first.
https://review.coreboot.org/c/coreboot/+/51024/comment/b111fc7f_f3ad53b8 PS5, Line 9: 1.adjust Please add a space after the dot.
https://review.coreboot.org/c/coreboot/+/51024/comment/f4b859bc_3837ce65 PS5, Line 10: to adjust tLOW. This fits on one line.
https://review.coreboot.org/c/coreboot/+/51024/comment/400c4f70_6345c827 PS5, Line 14: asurada(MT8192) Please add a space before the (.
-
Paul Menzel (Code Review)