build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25509 )
Change subject: [Do Not Merge] add i945G based mainboard ......................................................................
Patch Set 16:
(7 comments)
https://review.coreboot.org/#/c/25509/16/src/mainboard/nec/945g-m4/superio_h... File src/mainboard/nec/945g-m4/superio_hwm.c:
https://review.coreboot.org/#/c/25509/16/src/mainboard/nec/945g-m4/superio_h... PS16, Line 90: //if (get_option(&sysfan_temperature, "sysfan_temperature") != CB_SUCCESS) line over 80 characters
https://review.coreboot.org/#/c/25509/16/src/mainboard/nec/945g-m4/superio_h... PS16, Line 135: hwm_write(0x06, fan_speeds[cpufan_speed].fan_in); // CPUFANIN target speed line over 80 characters
https://review.coreboot.org/#/c/25509/16/src/mainboard/nec/945g-m4/superio_h... PS16, Line 140: temperatures[cpufan_temperature].deg_fahrenheit); line over 80 characters
https://review.coreboot.org/#/c/25509/16/src/mainboard/nec/945g-m4/superio_h... PS16, Line 141: hwm_write(0x06, temperatures[cpufan_temperature].deg_celsius); // CPUFANIN target temperature line over 80 characters
https://review.coreboot.org/#/c/25509/16/src/mainboard/nec/945g-m4/superio_h... PS16, Line 149: hwm_write(0x05, fan_speeds[sysfan_speed].fan_in); // SYSFANIN target speed line over 80 characters
https://review.coreboot.org/#/c/25509/16/src/mainboard/nec/945g-m4/superio_h... PS16, Line 154: temperatures[sysfan_temperature].deg_fahrenheit); line over 80 characters
https://review.coreboot.org/#/c/25509/16/src/mainboard/nec/945g-m4/superio_h... PS16, Line 155: hwm_write(0x05, temperatures[sysfan_temperature].deg_celsius); // SYSFANIN target temperature line over 80 characters
-
build bot (Jenkins) (Code Review)