Change in ...coreboot[master]: soc/intel/cannonlake/acpi: Add board level s0ix call back

[EricR Lai (Code Review)]

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32539

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

soc/intel/cannonlake/acpi: Add board level s0ix call back

Add board level s0ix call back. Since some driver doesn't
care _ON/_OFF method. Add a control method for s0ix usage.

BUG=b:129177593
TEST=NA

Signed-off-by: Eric Lai 
Change-Id: I404f388b19355ae89b36d1fb07f9fb4f97eb3b2d
---
M src/soc/intel/cannonlake/acpi/lpit.asl
1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/32539/1

diff --git a/src/soc/intel/cannonlake/acpi/lpit.asl b/src/soc/intel/cannonlake/acpi/lpit.asl
index 8515806..828efd0 100644
--- a/src/soc/intel/cannonlake/acpi/lpit.asl
+++ b/src/soc/intel/cannonlake/acpi/lpit.asl
@@ -14,6 +14,8 @@
  * GNU General Public License for more details.
  */

+External(_SB.MS0X, MethodObj)
+
 scope(_SB)
 {
    Device(LPID) {
@@ -62,12 +64,20 @@
    		 */
    		If(Arg2 == 5) {
    			_SB.PCI0.LPCB.EC0.S0IX(1)
+				/* provide board level s0ix hook */
+				If (CondRefOf (_SB.MS0X)) {
+					_SB.MS0X(1)
+				}
    		}
    		/*
    		 * Function 6.
    		 */
    		If(Arg2 == 6) {
    			_SB.PCI0.LPCB.EC0.S0IX(0)
+				/* provide board level s0ix hook */
+				If (CondRefOf (_SB.MS0X)) {
+					_SB.MS0X(1)
+				}
    		}
    	}
    	Return(Buffer(One) {0x00})

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32539 )

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

Patch Set 1:

Please take a look.

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32539 )

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32539 )

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/#/c/32539/1/src/soc/intel/cannonlake/acpi/lpit.a... 
File src/soc/intel/cannonlake/acpi/lpit.asl:

https://review.coreboot.org/#/c/32539/1/src/soc/intel/cannonlake/acpi/lpit.a... 
PS1, Line 79: 1
This should be 0.

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32539 )

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32539/1/src/soc/intel/cannonlake/acpi/lpit.a... 
File src/soc/intel/cannonlake/acpi/lpit.asl:

https://review.coreboot.org/#/c/32539/1/src/soc/intel/cannonlake/acpi/lpit.a... 
PS1, Line 79: 1
> This should be 0.

yes..

[EricR Lai (Code Review)]

Hello Patrick Rudolph, Duncan Laurie, Lijian Zhao, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32539

to look at the new patch set (#2).

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

soc/intel/cannonlake/acpi: Add board level s0ix call back

Add board level s0ix call back. Since some driver doesn't
care _ON/_OFF method. Add a control method for s0ix usage.

BUG=b:129177593
TEST=NA

Signed-off-by: Eric Lai 
Change-Id: I404f388b19355ae89b36d1fb07f9fb4f97eb3b2d
---
M src/soc/intel/cannonlake/acpi/lpit.asl
1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/32539/2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32539 )

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32539/1/src/soc/intel/cannonlake/acpi/lpit.a... 
File src/soc/intel/cannonlake/acpi/lpit.asl:

https://review.coreboot.org/#/c/32539/1/src/soc/intel/cannonlake/acpi/lpit.a... 
PS1, Line 79: 1
> yes..

Done

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32539 )

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

Patch Set 2: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32539 )

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32539 )

Change subject: soc/intel/cannonlake/acpi: Add board level s0ix call back
......................................................................

soc/intel/cannonlake/acpi: Add board level s0ix call back

Add board level s0ix call back. Since some driver doesn't
care _ON/_OFF method. Add a control method for s0ix usage.

BUG=b:129177593
TEST=NA

Signed-off-by: Eric Lai 
Change-Id: I404f388b19355ae89b36d1fb07f9fb4f97eb3b2d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32539
Tested-by: build bot (Jenkins) 
Reviewed-by: Duncan Laurie 
Reviewed-by: Furquan Shaikh 
---
M src/soc/intel/cannonlake/acpi/lpit.asl
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/soc/intel/cannonlake/acpi/lpit.asl b/src/soc/intel/cannonlake/acpi/lpit.asl
index 8515806..93bce26 100644
--- a/src/soc/intel/cannonlake/acpi/lpit.asl
+++ b/src/soc/intel/cannonlake/acpi/lpit.asl
@@ -14,6 +14,8 @@
  * GNU General Public License for more details.
  */

+External(_SB.MS0X, MethodObj)
+
 scope(_SB)
 {
    Device(LPID) {
@@ -62,12 +64,20 @@
    		 */
    		If(Arg2 == 5) {
    			_SB.PCI0.LPCB.EC0.S0IX(1)
+				/* provide board level s0ix hook */
+				If (CondRefOf (_SB.MS0X)) {
+					_SB.MS0X(1)
+				}
    		}
    		/*
    		 * Function 6.
    		 */
    		If(Arg2 == 6) {
    			_SB.PCI0.LPCB.EC0.S0IX(0)
+				/* provide board level s0ix hook */
+				If (CondRefOf (_SB.MS0X)) {
+					_SB.MS0X(0)
+				}
    		}
    	}
    	Return(Buffer(One) {0x00})