Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
mb/google/drallion: Add SPD files for drallion
This change adds seven SPD files for drallion
BUG=b:139397313 TEST=Compile successfully
Change-Id: I2f7e75fdbca4183bcd730e40fef4bfe280ab900b Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex M src/mainboard/google/drallion/variants/drallion/Makefile.inc M src/mainboard/google/drallion/variants/drallion/memory.c 9 files changed, 240 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/35346/1
diff --git a/src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex b/src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex new file mode 100644 index 0000000..5050647 --- /dev/null +++ b/src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 87 2E +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 AD 01 00 00 00 00 00 00 48 4D 41 38 35 31 53 +36 43 4A 52 36 4E 2D 56 4B 20 20 20 20 00 80 AD +FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex b/src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex new file mode 100644 index 0000000..1145389 --- /dev/null +++ b/src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 85 21 91 08 00 60 00 03 01 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 0C 2B 2D 04 +16 35 23 0D 00 00 2C 0B 03 24 35 0C 03 2D 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 43 CE +0F 11 20 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 EF 55 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 AD 01 00 00 00 00 00 00 48 4D 41 41 31 47 53 +36 43 4D 52 38 4E 2D 56 4B 20 20 20 20 00 80 AD +FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex b/src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex new file mode 100644 index 0000000..adc788f --- /dev/null +++ b/src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 85 21 00 08 00 60 00 03 01 03 00 00 +00 00 06 0D F8 FF 01 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 60 8D +0F 01 1F 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 7D 21 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 34 41 54 53 31 47 36 +34 48 5A 2D 32 47 36 45 31 20 20 20 20 31 80 2C +45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex b/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex new file mode 100644 index 0000000..410cac0 --- /dev/null +++ b/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 FF 01 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 60 5B +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 34 41 54 46 35 31 32 +36 34 48 5A 2D 32 47 36 45 31 20 20 20 31 80 2C +45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex b/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex new file mode 100644 index 0000000..1baacbc --- /dev/null +++ b/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 30 53 +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 34 41 54 46 35 31 32 +36 34 48 5A 2D 33 47 32 4A 31 20 20 20 31 80 2C +4A 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex b/src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex new file mode 100644 index 0000000..3e84f21 --- /dev/null +++ b/src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 87 2E +0F 11 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 DB 08 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 35 32 +34 34 43 42 30 2D 43 54 44 20 20 20 20 00 80 CE +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex b/src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex new file mode 100644 index 0000000..da1e198 --- /dev/null +++ b/src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 85 21 00 08 00 60 00 03 01 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 0C 2B 2D 04 +16 35 23 0D 00 00 2C 0B 03 24 35 0C 03 2D 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 D0 4E +0F 11 20 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 EF 55 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 31 4B +34 33 42 42 31 2D 43 54 44 20 20 20 20 00 80 CE +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/variants/drallion/Makefile.inc b/src/mainboard/google/drallion/variants/drallion/Makefile.inc index 8e070d2..942d00b 100644 --- a/src/mainboard/google/drallion/variants/drallion/Makefile.inc +++ b/src/mainboard/google/drallion/variants/drallion/Makefile.inc @@ -15,6 +15,13 @@
## GPP_F12-F16 indicates mem_id to match specific spd file SPD_SOURCES = empty_ddr4 # 0b00000 +SPD_SOURCES += micron_dimm_MT40A512M16LY-075E # 0b10100 +SPD_SOURCES += micron_dimm_MT40A512M16TB-062EJ # 0b11100 +SPD_SOURCES += micron_dimm_MT40A1G16KNR-075E # 0b10010 +SPD_SOURCES += hynix_dimm_H5AN8G6NCJR-VKC # 0b10001 +SPD_SOURCES += hynix_dimm_H5ANAG6NCMR-VKC # 0b11001 +SPD_SOURCES += samsung_dimm_K4A8G165WC-BCTD # 0b10011 +SPD_SOURCES += samsung_dimm_K4AAG165WB-MCTD # 0b11011
bootblock-y += gpio.c ramstage-y += gpio.c diff --git a/src/mainboard/google/drallion/variants/drallion/memory.c b/src/mainboard/google/drallion/variants/drallion/memory.c index e1755b4..67f4e56 100644 --- a/src/mainboard/google/drallion/variants/drallion/memory.c +++ b/src/mainboard/google/drallion/variants/drallion/memory.c @@ -17,6 +17,14 @@ #include <gpio.h> #include <variant/gpio.h>
+/* Use spd_index array to save mem_id */ +static const int spd_index[32] = { + 0,0,0,0,0,0,0,0, + 0,0,0,0,0,0,0,0, + 4,3,6,1,0,0,0,0, + 5,0,7,2,0,0,0,0, + }; + int variant_memory_sku(void) { gpio_t spd_gpios[] = { @@ -27,5 +35,5 @@ GPIO_MEM_CONFIG_4, };
- return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); + return spd_index[gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios))]; }
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
Patch Set 1:
(156 comments)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex:
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 1: 23 11 0C 03 85 21 91 08 00 60 00 03 01 03 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 2: 00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 3: 20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 0C 2B 2D 04 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 5: 16 35 23 0D 00 00 2C 0B 03 24 35 0C 03 2D 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 8: 00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 43 CE DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 9: 0F 11 20 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 16: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 EF 55 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 17: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 18: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 19: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 21: 80 AD 01 00 00 00 00 00 00 48 4D 41 41 31 47 53 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 36 43 4D 52 38 4E 2D 56 4B 20 20 20 20 00 80 AD DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 26: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 27: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 28: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 29: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 31: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 32: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex:
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 1: 23 11 0C 03 85 21 00 08 00 60 00 03 01 03 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 2: 00 00 06 0D F8 FF 01 00 6E 6E 6E 11 00 6E F0 0A DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 3: 20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 5: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 8: 00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 60 8D DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 9: 0F 01 1F 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 16: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 7D 21 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 17: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 18: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 19: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 21: 80 2C 00 00 00 00 00 00 00 34 41 54 53 31 47 36 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 34 48 5A 2D 32 47 36 45 31 20 20 20 20 31 80 2C DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 26: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 27: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 28: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 29: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 31: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 32: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex:
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 1: 23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 2: 00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 3: 20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 5: 16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 8: 00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 30 53 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 9: 0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 16: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 17: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 18: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 19: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 21: 80 2C 00 00 00 00 00 00 00 34 41 54 46 35 31 32 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 36 34 48 5A 2D 33 47 32 4A 31 20 20 20 31 80 2C DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 4A 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 26: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 27: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 28: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 29: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 31: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 32: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex:
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 1: 23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 2: 00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 3: 20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 4: 00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 5: 16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 6: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 7: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 8: 00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 87 2E DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 9: 0F 11 02 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 11: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 12: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 13: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 14: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 15: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 16: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DB 08 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 17: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 18: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 19: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 20: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 21: 80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 35 32 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 34 34 43 42 30 2D 43 54 44 20 20 20 20 00 80 CE DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 26: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 27: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 28: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 29: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 31: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 32: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 DOS line endings
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/memory.c:
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/1/src/mainboard/google/dralli... PS1, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
Hello Ivy Jian, EricR Lai, Alan Lee, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35346
to look at the new patch set (#2).
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
mb/google/drallion: Add SPD files for drallion
This change adds seven SPD files for drallion
BUG=b:139397313 TEST=Compile successfully
Change-Id: I2f7e75fdbca4183bcd730e40fef4bfe280ab900b Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex M src/mainboard/google/drallion/variants/drallion/Makefile.inc M src/mainboard/google/drallion/variants/drallion/memory.c 9 files changed, 240 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/35346/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
Patch Set 2:
(28 comments)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/memory.c:
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 22: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 23: 0,0,0,0,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 24: 4,3,6,1,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35346/2/src/mainboard/google/dralli... PS2, Line 25: 5,0,7,2,0,0,0,0, space required after that ',' (ctx:VxV)
Hello Ivy Jian, EricR Lai, build bot (Jenkins), Alan Lee, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35346
to look at the new patch set (#3).
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
mb/google/drallion: Add SPD files for drallion
This change adds seven SPD files for drallion
BUG=b:139397313 TEST=Compile successfully
Change-Id: I2f7e75fdbca4183bcd730e40fef4bfe280ab900b Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex M src/mainboard/google/drallion/variants/drallion/Makefile.inc M src/mainboard/google/drallion/variants/drallion/memory.c 9 files changed, 240 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/35346/3
EricR Lai has uploaded a new patch set (#4) to the change originally created by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
mb/google/drallion: Add SPD files for drallion
This change adds SPD files for Drallion. Use spd_index matrix to correspond mem_id. This can save the dummy spd index to reduce the size of SPD.bin.
BUG=b:139397313 TEST=Compile successfully
Change-Id: I2f7e75fdbca4183bcd730e40fef4bfe280ab900b Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex M src/mainboard/google/drallion/variants/drallion/Makefile.inc M src/mainboard/google/drallion/variants/drallion/memory.c 9 files changed, 240 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/35346/4
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35346/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/memory.c:
https://review.coreboot.org/c/coreboot/+/35346/3/src/mainboard/google/dralli... PS3, Line 20: /* Use spd_index array to save mem_id */ Use spd_index matrix to correspond mem_id. And we can save the dummy spd index to reduce the size of SPD.bin.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
Patch Set 5: Code-Review+1
Selma Bensaid has uploaded a new patch set (#7) to the change originally created by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
mb/google/drallion: Add SPD files for drallion
This change adds SPD files for Drallion. Use spd_index matrix to correspond mem_id. This can save the dummy spd index to reduce the size of SPD.bin.
BUG=b:139397313 TEST=Compile successfully
Change-Id: I2f7e75fdbca4183bcd730e40fef4bfe280ab900b Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex M src/mainboard/google/drallion/variants/drallion/Makefile.inc M src/mainboard/google/drallion/variants/drallion/memory.c 9 files changed, 240 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/35346/7
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35346/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/memory.c:
https://review.coreboot.org/c/coreboot/+/35346/3/src/mainboard/google/dralli... PS3, Line 20: /* Use spd_index array to save mem_id */
Use spd_index matrix to correspond mem_id. […]
Ack
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
Patch Set 8: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35346 )
Change subject: mb/google/drallion: Add SPD files for drallion ......................................................................
mb/google/drallion: Add SPD files for drallion
This change adds SPD files for Drallion. Use spd_index matrix to correspond mem_id. This can save the dummy spd index to reduce the size of SPD.bin.
BUG=b:139397313 TEST=Compile successfully
Change-Id: I2f7e75fdbca4183bcd730e40fef4bfe280ab900b Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35346 Reviewed-by: John Su john_su@compal.corp-partner.google.com Reviewed-by: Mathew King mathewk@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex A src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex A src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex A src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex M src/mainboard/google/drallion/variants/drallion/Makefile.inc M src/mainboard/google/drallion/variants/drallion/memory.c 9 files changed, 240 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified John Su: Looks good to me, approved Mathew King: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex b/src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex new file mode 100644 index 0000000..5050647 --- /dev/null +++ b/src/mainboard/google/drallion/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 87 2E +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 AD 01 00 00 00 00 00 00 48 4D 41 38 35 31 53 +36 43 4A 52 36 4E 2D 56 4B 20 20 20 20 00 80 AD +FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex b/src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex new file mode 100644 index 0000000..bd226e1 --- /dev/null +++ b/src/mainboard/google/drallion/spd/hynix_dimm_H5ANAG6NCMR-VKC.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 85 21 91 08 00 60 00 03 01 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 0C 2B 2D 04 +16 35 23 0D 00 00 2C 0B 03 24 35 0C 03 2D 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 43 CE +0F 11 20 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 EF 55 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 AD 01 00 00 00 00 00 00 48 4D 41 41 31 47 53 +36 43 4D 52 38 4E 2D 56 4B 20 20 20 20 00 80 AD +FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex b/src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex new file mode 100644 index 0000000..334ec9a --- /dev/null +++ b/src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KNR-075E.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 85 21 00 08 00 60 00 03 01 03 00 00 +00 00 06 0D F8 FF 01 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 60 8D +0F 01 1F 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 7D 21 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 34 41 54 53 31 47 36 +34 48 5A 2D 32 47 36 45 31 20 20 20 20 31 80 2C +45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex b/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex new file mode 100644 index 0000000..410cac0 --- /dev/null +++ b/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16LY-075E.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 FF 01 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 60 5B +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 34 41 54 46 35 31 32 +36 34 48 5A 2D 32 47 36 45 31 20 20 20 31 80 2C +45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex b/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex new file mode 100644 index 0000000..dd6806c --- /dev/null +++ b/src/mainboard/google/drallion/spd/micron_dimm_MT40A512M16TB-062EJ.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 05 0D F8 FF 2B 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 30 53 +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 34 41 54 46 35 31 32 +36 34 48 5A 2D 33 47 32 4A 31 20 20 20 31 80 2C +4A 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex b/src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex new file mode 100644 index 0000000..8620d53 --- /dev/null +++ b/src/mainboard/google/drallion/spd/samsung_dimm_K4A8G165WC-BCTD.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 87 2E +0F 11 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 DB 08 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 35 32 +34 34 43 42 30 2D 43 54 44 20 20 20 20 00 80 CE +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex b/src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex new file mode 100644 index 0000000..da1e198 --- /dev/null +++ b/src/mainboard/google/drallion/spd/samsung_dimm_K4AAG165WB-MCTD.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 85 21 00 08 00 60 00 03 01 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 18 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 0C 2B 2D 04 +16 35 23 0D 00 00 2C 0B 03 24 35 0C 03 2D 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 D0 4E +0F 11 20 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 EF 55 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 31 4B +34 33 42 42 31 2D 43 54 44 20 20 20 20 00 80 CE +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/drallion/variants/drallion/Makefile.inc b/src/mainboard/google/drallion/variants/drallion/Makefile.inc index 8e070d2..942d00b 100644 --- a/src/mainboard/google/drallion/variants/drallion/Makefile.inc +++ b/src/mainboard/google/drallion/variants/drallion/Makefile.inc @@ -15,6 +15,13 @@
## GPP_F12-F16 indicates mem_id to match specific spd file SPD_SOURCES = empty_ddr4 # 0b00000 +SPD_SOURCES += micron_dimm_MT40A512M16LY-075E # 0b10100 +SPD_SOURCES += micron_dimm_MT40A512M16TB-062EJ # 0b11100 +SPD_SOURCES += micron_dimm_MT40A1G16KNR-075E # 0b10010 +SPD_SOURCES += hynix_dimm_H5AN8G6NCJR-VKC # 0b10001 +SPD_SOURCES += hynix_dimm_H5ANAG6NCMR-VKC # 0b11001 +SPD_SOURCES += samsung_dimm_K4A8G165WC-BCTD # 0b10011 +SPD_SOURCES += samsung_dimm_K4AAG165WB-MCTD # 0b11011
bootblock-y += gpio.c ramstage-y += gpio.c diff --git a/src/mainboard/google/drallion/variants/drallion/memory.c b/src/mainboard/google/drallion/variants/drallion/memory.c index e1755b4..c837805 100644 --- a/src/mainboard/google/drallion/variants/drallion/memory.c +++ b/src/mainboard/google/drallion/variants/drallion/memory.c @@ -17,6 +17,14 @@ #include <gpio.h> #include <variant/gpio.h>
+/* Use spd_index array to save mem_id */ +static const int spd_index[32] = { + 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, + 4, 3, 6, 1, 0, 0, 0, 0, + 5, 0, 7, 2, 0, 0, 0, 0 + }; + int variant_memory_sku(void) { gpio_t spd_gpios[] = { @@ -27,5 +35,5 @@ GPIO_MEM_CONFIG_4, };
- return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); + return spd_index[gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios))]; }
-
Amanda Hwang (Code Review) -
build bot (Jenkins) (Code Review)
-
EricR Lai (Code Review)
-
John Su (Code Review)
-
Mathew King (Code Review)
-
Patrick Georgi (Code Review)
-
Selma Bensaid (Code Review)