Attention is currently required from: V Sowmya, Aamir Bohra.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50993 )
Change subject: Revert "Revert "mb/intel/shadowmountain: Add the ASL code""
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50993/comment/eec345ed_c5b9c18f
PS2, Line 7: Revert "Revert "mb/intel/shadowmountain: Add the ASL code""
Even if this change is a revert of a revert, I'd simply say:
mb/intel/shadowmountain: Add ASL code
File src/mainboard/intel/shadowmountain/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/50993/comment/71e2b70f_0f395047
PS2, Line 22: /* CPU */
nit: drop this comment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5aa60730fc9b93fa97b2bafbb8b2714b6b37becc
Gerrit-Change-Number: 50993
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Mon, 22 Feb 2021 08:56:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment