Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/28198 )
Change subject: Makefile.inc: Fix dependency tracking of fmap{_config.h,.desc}
......................................................................
Patch Set 2:
The code looks quite strange and in fact, these are false dependencies. If you e.g. `touch fmap.fmap`, `make` will call `true` in an attempt to update `fmap_config.h`, every time without real success.
If you have a recipe like the one for `fmap.fmap` that builds a number of targets, then the right thing to do is to define multiple targets in the rule: https://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html
Feel free to update the fix :)
--
To view, visit
https://review.coreboot.org/28198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7ecb88cf7df7f2488defd47ea02255fc10a67e9
Gerrit-Change-Number: 28198
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-CC: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 14 Sep 2018 00:09:31 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No