Change in ...coreboot[master]: siemens/mc_apl4: provide CLK on Pin PMU_SUSCLK SMARC module
Uwe Poeche has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32168
Change subject: siemens/mc_apl4: provide CLK on Pin PMU_SUSCLK SMARC module ......................................................................
siemens/mc_apl4: provide CLK on Pin PMU_SUSCLK SMARC module
This patch provides an clock on Pin PMU_SUSCLK. This is necessary for correct function of the SMARC module.
Test=mc_apl4 flashed, booted into Linux, ckecked CLK with scope
Change-Id: Ieb1d66b5a09363c9bed2b19e7a204f206ee04158 Signed-off-by: Uwe Poeche uwe.poeche@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/32168/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c index 40b2c93..2bd56b8 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c @@ -131,7 +131,6 @@ PAD_CFG_GPI(PMU_SLP_S0_B, UP_20K, DEEP), PAD_CFG_GPI(PMU_SLP_S3_B, UP_20K, DEEP), PAD_CFG_GPI(PMU_SLP_S4_B, UP_20K, DEEP), - PAD_CFG_GPI(PMU_SUSCLK, DN_20K, DEEP), PAD_CFG_GPI(PMU_WAKE_B, DN_20K, DEEP), PAD_CFG_GPI(SUS_STAT_B, DN_20K, DEEP), PAD_CFG_GPI(SUSPWRDNACK, DN_20K, DEEP), @@ -380,6 +379,8 @@ PAD_CFG_NF(GPIO_43, UP_20K, DEEP, NF1), /* LPSS_UART1_TXD */ PAD_CFG_NF(GPIO_46, UP_20K, DEEP, NF1), /* LPSS_UART2_RXD */ PAD_CFG_NF(GPIO_47, UP_20K, DEEP, NF1), /* LPSS_UART2_TXD */ + + PAD_CFG_NF(PMU_SUSCLK, NONE, DEEP, NF1),/* 32,78 kHz used on SMARC */ };
const struct pad_config *variant_early_gpio_table(size_t *num)
Hello Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32168
to look at the new patch set (#2).
Change subject: siemens/mc_apl4: provide CLK on APL Pin PMU_SUSCLK ......................................................................
siemens/mc_apl4: provide CLK on APL Pin PMU_SUSCLK
This patch provides an clock on Pin PMU_SUSCLK. This is necessary for correct function of the SMARC module.
Test=mc_apl4 flashed, booted into Linux, ckecked CLK with scope
Change-Id: Ieb1d66b5a09363c9bed2b19e7a204f206ee04158 Signed-off-by: Uwe Poeche uwe.poeche@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/32168/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32168 )
Change subject: siemens/mc_apl4: provide CLK on APL Pin PMU_SUSCLK ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/32168/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32168/2//COMMIT_MSG@7 PS2, Line 7: provide Provide
https://review.coreboot.org/#/c/32168/2//COMMIT_MSG@9 PS2, Line 9: an a
Hello Werner Zeh, Mario Scheithauer, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32168
to look at the new patch set (#3).
Change subject: siemens/mc_apl4: Provide CLK on APL Pin PMU_SUSCLK ......................................................................
siemens/mc_apl4: Provide CLK on APL Pin PMU_SUSCLK
This patch provides a clock on Pin PMU_SUSCLK. This is necessary for correct function of the SMARC module.
Test=mc_apl4 flashed, booted into Linux, ckecked CLK with scope
Change-Id: Ieb1d66b5a09363c9bed2b19e7a204f206ee04158 Signed-off-by: Uwe Poeche uwe.poeche@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/32168/3
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32168 )
Change subject: siemens/mc_apl4: Provide CLK on APL Pin PMU_SUSCLK ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32168 )
Change subject: siemens/mc_apl4: Provide CLK on APL Pin PMU_SUSCLK ......................................................................
siemens/mc_apl4: Provide CLK on APL Pin PMU_SUSCLK
This patch provides a clock on Pin PMU_SUSCLK. This is necessary for correct function of the SMARC module.
Test=mc_apl4 flashed, booted into Linux, ckecked CLK with scope
Change-Id: Ieb1d66b5a09363c9bed2b19e7a204f206ee04158 Signed-off-by: Uwe Poeche uwe.poeche@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32168 Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Mario Scheithauer: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c index 40b2c93..2bd56b8 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c @@ -131,7 +131,6 @@ PAD_CFG_GPI(PMU_SLP_S0_B, UP_20K, DEEP), PAD_CFG_GPI(PMU_SLP_S3_B, UP_20K, DEEP), PAD_CFG_GPI(PMU_SLP_S4_B, UP_20K, DEEP), - PAD_CFG_GPI(PMU_SUSCLK, DN_20K, DEEP), PAD_CFG_GPI(PMU_WAKE_B, DN_20K, DEEP), PAD_CFG_GPI(SUS_STAT_B, DN_20K, DEEP), PAD_CFG_GPI(SUSPWRDNACK, DN_20K, DEEP), @@ -380,6 +379,8 @@ PAD_CFG_NF(GPIO_43, UP_20K, DEEP, NF1), /* LPSS_UART1_TXD */ PAD_CFG_NF(GPIO_46, UP_20K, DEEP, NF1), /* LPSS_UART2_RXD */ PAD_CFG_NF(GPIO_47, UP_20K, DEEP, NF1), /* LPSS_UART2_TXD */ + + PAD_CFG_NF(PMU_SUSCLK, NONE, DEEP, NF1),/* 32,78 kHz used on SMARC */ };
const struct pad_config *variant_early_gpio_table(size_t *num)
-
Mario Scheithauer (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Uwe Poeche (Code Review)