Patrick Georgi merged this change.

View Change

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Mario Scheithauer: Looks good to me, approved
siemens/mc_apl4: Provide CLK on APL Pin PMU_SUSCLK

This patch provides a clock on Pin PMU_SUSCLK. This is necessary for correct
function of the SMARC module.

Test=mc_apl4 flashed, booted into Linux, ckecked CLK with scope

Change-Id: Ieb1d66b5a09363c9bed2b19e7a204f206ee04158
Signed-off-by: Uwe Poeche <uwe.poeche@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32168
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c
index 40b2c93..2bd56b8 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c
@@ -131,7 +131,6 @@
PAD_CFG_GPI(PMU_SLP_S0_B, UP_20K, DEEP),
PAD_CFG_GPI(PMU_SLP_S3_B, UP_20K, DEEP),
PAD_CFG_GPI(PMU_SLP_S4_B, UP_20K, DEEP),
- PAD_CFG_GPI(PMU_SUSCLK, DN_20K, DEEP),
PAD_CFG_GPI(PMU_WAKE_B, DN_20K, DEEP),
PAD_CFG_GPI(SUS_STAT_B, DN_20K, DEEP),
PAD_CFG_GPI(SUSPWRDNACK, DN_20K, DEEP),
@@ -380,6 +379,8 @@
PAD_CFG_NF(GPIO_43, UP_20K, DEEP, NF1), /* LPSS_UART1_TXD */
PAD_CFG_NF(GPIO_46, UP_20K, DEEP, NF1), /* LPSS_UART2_RXD */
PAD_CFG_NF(GPIO_47, UP_20K, DEEP, NF1), /* LPSS_UART2_TXD */
+
+ PAD_CFG_NF(PMU_SUSCLK, NONE, DEEP, NF1),/* 32,78 kHz used on SMARC */
};

const struct pad_config *variant_early_gpio_table(size_t *num)

To view, visit change 32168. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb1d66b5a09363c9bed2b19e7a204f206ee04158
Gerrit-Change-Number: 32168
Gerrit-PatchSet: 4
Gerrit-Owner: Uwe Poeche <uwe.poeche@siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer@siemens.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Uwe Poeche <uwe.poeche@siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged