Attention is currently required from: Arthur Heymans, Nico Huber, ron minnich.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry
......................................................................
Patch Set 4:
(2 comments)
File util/cbfstool/linux_trampoline.S:
https://review.coreboot.org/c/coreboot/+/62574/comment/3ae853f4_729401e8
PS2, Line 97: ACPI_RSDP_ADDR
Was this location unused in earlier zero page versions? i.e. no
version check needed?
Right it was unused so version checks should not be needed.
https://review.coreboot.org/c/coreboot/+/62574/comment/779b03b4_d5c63f85
PS2, Line 100:
`jmp .endScan` I guess? This is a path where we know the next `cmp` will […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62574
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I688b94608b03b0177c42d2834c7e3beb802ae686
Gerrit-Change-Number: 62574
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:16:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment