Attention is currently required from: Felix Singer, Sean Rhodes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74328 )
Change subject: device: Correct D3Cold Kconfig option
......................................................................
Patch Set 2:
(2 comments)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/74328/comment/da21f3ae_a27ae731
PS2, Line 1008: "Support D3Cold"
If this is really something the person who configures coreboot should decide,
then the help text should explain it in full detail. Ideally, we wouldn't
even assume that this person has heard about things like D3Cold or RTD3.
https://review.coreboot.org/c/coreboot/+/74328/comment/1983fb41_b726b820
PS2, Line 1012: any
Should be `all` now, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bdb6589e98ac81d0ce25df52fb916b5c2fd0157
Gerrit-Change-Number: 74328
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Wed, 12 Apr 2023 12:24:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment