Attention is currently required from: Subrata Banik, Tim Wawrzynczak, EricR Lai.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63159 )
Change subject: soc/intel/common: Add Kconfig SOC_INTEL_CSE_SET_EOP
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Yes, while rebasing for platform (which does not select this Kconfig SOC_INTEL_CSE_EOP) build, it […]
I am working on platform other than MTL at early stage. If selecting SOC_INTEL_CS_EOP, do_send_end_of_post causes reboot. TBD for root cause.
static void cse_final_ready_to_boot(void)
{
if (CONFIG(SOC_INTEL_CSE_SET_EOP))
cse_send_end_of_post();
cse_control_global_reset_lock();
if (CONFIG(DISABLE_HECI1_AT_PRE_BOOT)) {
cse_set_to_d0i3();
heci1_disable();
}
}
Along with DISABLE_HECI1_AT_PRE_BOOT for heci1_disable(), it would be proper to add this CONFIG(SOC_INTEL_CSE_SET_EOP) for cse_send_end_of_post().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib52404d9ad4c01a460e4cfef331c529d2a53337a
Gerrit-Change-Number: 63159
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 29 Mar 2022 05:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Gerrit-MessageType: comment