Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46274 )
Change subject: {cpu,soc}/intel: deduplicate cpu code
......................................................................
Patch Set 22: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46274/22/src/include/cpu/intel/msr....
File src/include/cpu/intel/msr.h:
https://review.coreboot.org/c/coreboot/+/46274/22/src/include/cpu/intel/msr....
PS22, Line 12: #define MSR_PIC_MSG_CONTROL 0x2e
Since all related SoCs use common code now, I think you can remove this from their header files.
For example:
soc/intel/cannonlake/include/soc/msr.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0cc834de8492d59c423317598e1c11847a0b1ab
Gerrit-Change-Number: 46274
Gerrit-PatchSet: 22
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Oct 2020 21:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment