Attention is currently required from: Angel Pons, Maximilian Brune, David Milosevic.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 8:
(5 comments)
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163777): https://review.coreboot.org/c/coreboot/+/68137/comment/f9e106c8_e51ff779 PS8, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163777): https://review.coreboot.org/c/coreboot/+/68137/comment/c0ca53dd_19acda66 PS8, Line 89: switch (access) { switch and case should be at the same indent
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163777): https://review.coreboot.org/c/coreboot/+/68137/comment/8e7f8510_46bbff41 PS8, Line 40: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163777): https://review.coreboot.org/c/coreboot/+/68137/comment/9476540b_6c4acbed PS8, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163777): https://review.coreboot.org/c/coreboot/+/68137/comment/f1a0e130_ff767524 PS8, Line 34: switch (vpd) { switch and case should be at the same indent