Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Angel Pons, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67938 )
Change subject: soc/amd/mendocino: Set up SoC-specific XHCI defines
......................................................................
Patch Set 10:
(4 comments)
File src/soc/amd/mendocino/Kconfig:
https://review.coreboot.org/c/coreboot/+/67938/comment/4738bfd1_7202fe7c
PS7, Line 51: select SMM_PCI_BAR_STORE
Put this in the amd/common XHCI Kconfig?
Done
File src/soc/amd/mendocino/xhci.c:
PS7:
Different CL please
Done
File src/soc/amd/mendocino/xhci_elog.c:
https://review.coreboot.org/c/coreboot/+/67938/comment/353c661a_6dd8d7f0
PS7, Line 6:
Does this need to be a struct that's defined in a C file? The preference for these sorts of things […]
`DEV_PTR` can't be used to initialize static structs so I've restructured the code to use defines instead.
https://review.coreboot.org/c/coreboot/+/67938/comment/b385a9a1_3bb17971
PS7, Line 9: .usb2_port_status_reg = 0x420,
: .num_usb2_ports = 2,
: .usb3_port_status_reg = 0x440,
: .num_usb3_ports = 1
Why the magic numbers? We can use the functions in https://source.chromium. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67938
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16c789ff673c26ded84e4d46ab6dc743f33c5bb7
Gerrit-Change-Number: 67938
Gerrit-PatchSet: 10
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 28 Nov 2022 16:49:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment