Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46471 )
Change subject: soc/intel/common/acpi,mb/*: replace LPID with PEPD ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46471/4/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/pep.asl:
https://review.coreboot.org/c/coreboot/+/46471/4/src/soc/intel/common/block/... PS4, Line 19: Name(_HID, "INT33A1") /* Intel Power Engine */
this still crashes Windows with `INTERNAL_POWER_ERROR`, even though refcode and vendor code have it
Done
https://review.coreboot.org/c/coreboot/+/46471/4/src/soc/intel/common/block/... PS4, Line 30: 0x60
this means "not supported"; refcode and vendor return 0x7F
Done
https://review.coreboot.org/c/coreboot/+/46471/4/src/soc/intel/common/block/... PS4, Line 36: Return(Package(5) {0, Ones, Ones, Ones, Ones
wrong. […]
Done
https://review.coreboot.org/c/coreboot/+/46471/4/src/soc/intel/common/block/... PS4, Line 42: Return(Buffer(One) {0x0})
same as function 1
Done
-
Michael Niewöhner (Code Review)