Change in coreboot[master]: mb/intel/adlrvp: Configure SATA DEVSLP as per latest schematics - coreboot-gerrit

27 Jan 2021


      Attention is currently required from: Tim Wawrzynczak, Subrata Banik.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49964 )
Change subject: mb/intel/adlrvp: Configure SATA DEVSLP as per latest schematics
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/intel/adlrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/49964/comment/bb21db37_34e483b9 
PS1, Line 230: NF4
...
In all the versions I have access to, I see NF4 as ISH. […]
There is some inconsistency in the document I see and the document you are referring to. I will file a separate bug to follow up on it. Thanks Subrata!
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I588a8c1153eaa1bf818a081c6c5d18a669017d95
Gerrit-Change-Number: 49964
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 27 Jan 2021 18:45:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment