Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro.
Subrata Banik has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/86170?usp=email )
Change subject: soc/intel/alderlake/romstage: Update UFS disable sequence
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/86170/comment/80c00937_ed750faa?usp... :
PS3, Line 202: if ((ps->prev_sleep_state == ACPI_S5 ||
: cse_match_current_pm_event(PWR_CYCLE_RESET_CMOFF)) &&
: !mainboard_expects_another_reset()) {
with this CL, do we still need CB:86111 ?
I believe we can avoid sending side band communication in all other boots like S0 cycles ? the code logic in 202-204 is enough to enforce disabling UFS and issue a warm reboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85cad1a1eb00a2a7f520a57cda789ad6737fcb97
Gerrit-Change-Number: 86170
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 28 Jan 2025 11:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No