Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69429 )
Change subject: amdfwtool: Set the base address of AMDFW as relative ......................................................................
Patch Set 4:
(7 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163261): https://review.coreboot.org/c/coreboot/+/69429/comment/955726ff_f80c766d PS4, Line 2294: case 0: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163261): https://review.coreboot.org/c/coreboot/+/69429/comment/7e9ebf2d_d62f03a6 PS4, Line 2295: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163261): https://review.coreboot.org/c/coreboot/+/69429/comment/9e0e5429_c0350297 PS4, Line 2296: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163261): https://review.coreboot.org/c/coreboot/+/69429/comment/a0ac7a8a_090b52f0 PS4, Line 2297: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163261): https://review.coreboot.org/c/coreboot/+/69429/comment/962d65a1_b7c799ff PS4, Line 2298: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163261): https://review.coreboot.org/c/coreboot/+/69429/comment/60be42d9_c30d413e PS4, Line 2299: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163261): https://review.coreboot.org/c/coreboot/+/69429/comment/5853e53b_bd5a4c9c PS4, Line 2300: case 0x020000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
-
build bot (Jenkins) (Code Review)