Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31677 )
Change subject: device/pci_ops: Avoid name collisions
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31677/1/src/arch/x86/include/arch/pci_io_cfg...
File src/arch/x86/include/arch/pci_io_cfg.h:
https://review.coreboot.org/#/c/31677/1/src/arch/x86/include/arch/pci_io_cfg...
PS1, Line 81:
Add a comment describing what 's' means?
/* Avoid name collisions as different stages have different signature
* for these functions. The _s_ stands for simple, fundamental IO or
* MMIO variant.
*/
Would that do it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20f56cfe3ac7dc4421e62a99ca91f39a857c0ccf
Gerrit-Change-Number: 31677
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Mar 2019 18:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment