Change in coreboot[master]: mb/google/zork: expose stop gpio for trembyle

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Aaron Durbin (Code Review)

5 Aug 2020 5 Aug '20

10:39 p.m.

Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

mb/google/zork: expose stop gpio for trembyle

In CB:43701 the trembyle touchscreen parameters were not updated to expose the stop gpio properly.

BUG=b:162973325

Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/trembyle/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44254/1

diff --git a/src/mainboard/google/zork/variants/trembyle/overridetree.cb b/src/mainboard/google/zork/variants/trembyle/overridetree.cb index 26d9a3e..de038ac 100644 --- a/src/mainboard/google/zork/variants/trembyle/overridetree.cb +++ b/src/mainboard/google/zork/variants/trembyle/overridetree.cb @@ -75,6 +75,8 @@ # 32ms: Rise time of the reset line # 20ms: Firmware ready time register "reset_delay_ms" = "32 + 20" + register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" + register "stop_off_delay_ms" = "1" register "has_power_resource" = "1" register "disable_gpio_export_in_crs" = "1" device i2c 39 on end

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by thread

Aaron Durbin (Code Review)

5 Aug 5 Aug

10:42 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

Patch Set 1:

Martin, can you test locally? I don't have a trembyle I can actually touch (it's remote).

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 1 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Comment-Date: Wed, 05 Aug 2020 22:42:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:48 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 1 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Comment-Date: Wed, 05 Aug 2020 22:48:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

7 Aug 7 Aug

9:01 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

Patch Set 1: Code-Review-2

No sure this fixes anything yet w/o a confirmation.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 1 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 07 Aug 2020 21:01:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

12 Aug 12 Aug

3:04 a.m.

Furquan Shaikh has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

Removed Code-Review+2 by Furquan Shaikh furquan@google.com

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 1 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteVote

Furquan Shaikh (Code Review)

3:04 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44254/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/trembyle/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/44254/1/src/mainboard/google/zork/v... PS1, Line 78: ACPI_GPIO_OUTPUT_ACTIVE_HIGH This needs to be ACTIVE_LOW. With that, I am able to get touchscreen working again on my Trembyle.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 1 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Aug 2020 03:04:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aaron Durbin (Code Review)

2:14 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44254

to look at the new patch set (#2).

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

mb/google/zork: expose stop gpio for trembyle

In CB:43701 the trembyle touchscreen parameters were not updated to expose the stop gpio properly.

BUG=b:162973325

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44254/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 2 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Aaron Durbin (Code Review)

2:15 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44254/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/trembyle/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/44254/1/src/mainboard/google/zork/v... PS1, Line 78: ACPI_GPIO_OUTPUT_ACTIVE_HIGH

...

This needs to be ACTIVE_LOW. With that, I am able to get touchscreen working again on my Trembyle.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 2 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Aug 2020 14:15:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:40 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

Patch Set 2: Code-Review+2

We have some other entries in zork which are still using ACTIVE_HIGH for stop_gpio:

git grep "stop_gpio" | grep ACTIVE_HIGH src/mainboard/google/zork/variants/dalboz/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" src/mainboard/google/zork/variants/morphius/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" src/mainboard/google/zork/variants/vilboz/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"

Those will have to be audited as well.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 2 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Aug 2020 17:40:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

5:56 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

Patch Set 2: -Code-Review

...

Patch Set 2: Code-Review+2

We have some other entries in zork which are still using ACTIVE_HIGH for stop_gpio:

git grep "stop_gpio" | grep ACTIVE_HIGH src/mainboard/google/zork/variants/dalboz/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" src/mainboard/google/zork/variants/morphius/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" src/mainboard/google/zork/variants/vilboz/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"

Those will have to be audited as well.

I filed an issue for that: https://issuetracker.google.com/163816078

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 2 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Aug 2020 17:56:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

5:56 p.m.

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44254 )

Change subject: mb/google/zork: expose stop gpio for trembyle ......................................................................

mb/google/zork: expose stop gpio for trembyle

In CB:43701 the trembyle touchscreen parameters were not updated to expose the stop gpio properly.

BUG=b:162973325

Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Signed-off-by: Aaron Durbin adurbin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/44254 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/trembyle/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/trembyle/overridetree.cb b/src/mainboard/google/zork/variants/trembyle/overridetree.cb index 001403c..9155567 100644 --- a/src/mainboard/google/zork/variants/trembyle/overridetree.cb +++ b/src/mainboard/google/zork/variants/trembyle/overridetree.cb @@ -73,6 +73,8 @@ # 32ms: Rise time of the reset line # 20ms: Firmware ready time register "reset_delay_ms" = "32 + 20" + register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)" + register "stop_off_delay_ms" = "1" register "has_power_resource" = "1" device i2c 39 on end end

-- To view, visit https://review.coreboot.org/c/coreboot/+/44254 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0 Gerrit-Change-Number: 44254 Gerrit-PatchSet: 3 Gerrit-Owner: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1376

days inactive

1383

days old

coreboot-gerrit@coreboot.org

10 comments

2 participants

tags (0)

participants (2)

Aaron Durbin (Code Review)
Furquan Shaikh (Code Review)