We have some other entries in zork which are still using ACTIVE_HIGH for stop_gpio:

git grep "stop_gpio" | grep ACTIVE_HIGH
src/mainboard/google/zork/variants/dalboz/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
src/mainboard/google/zork/variants/morphius/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"
src/mainboard/google/zork/variants/vilboz/overridetree.cb: register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)"

Those will have to be audited as well.

Patch set 2:Code-Review +2

View Change

To view, visit change 44254. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0
Gerrit-Change-Number: 44254
Gerrit-PatchSet: 2
Gerrit-Owner: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 12 Aug 2020 17:40:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment