Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22688
Change subject: soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT ......................................................................
soc/intel/skylake: Fix DSX_CFG macro name for AC_PRESENT
DSX_CFG provides a config option to disable internal pull-down on AC_PRESENT. This change updates macro name to reflect this correctly.
Change-Id: I291112858c4ce36667edf30fe303fed437baf5d2 Signed-off-by: Furquan Shaikh furquan@chromium.org --- M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/include/soc/pmc.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22688/1
diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index e539019..4db8382 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -87,7 +87,7 @@ * Deep Sx Configuration * DSX_EN_WAKE_PIN - Enable WAKE# pin * DSX_EN_LAN_WAKE_PIN - Enable LAN_WAKE# pin - * DSX_EN_AC_PRESENT_PIN - Enable AC_PRESENT pin + * DSX_DIS_AC_PRESENT_PD - Disable pull-down on AC_PRESENT pin */ uint32_t deep_sx_config;
diff --git a/src/soc/intel/skylake/include/soc/pmc.h b/src/soc/intel/skylake/include/soc/pmc.h index bd86f95..36c4a13 100644 --- a/src/soc/intel/skylake/include/soc/pmc.h +++ b/src/soc/intel/skylake/include/soc/pmc.h @@ -87,7 +87,7 @@ #define DSX_CFG 0x34 #define DSX_CFG_MASK 0x7 #define DSX_EN_WAKE_PIN (1 << 2) -#define DSX_EN_AC_PRESENT_PIN (1 << 1) +#define DSX_DIS_AC_PRESENT_PD (1 << 1) #define DSX_EN_LAN_WAKE_PIN (1 << 0) #define PMSYNC_TPR_CFG 0xc4 #define PMSYNC_LOCK (1 << 31)