Attention is currently required from: Felix Singer, Raul Rangel, Nick Vaccaro, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60060 )
Change subject: mb/google/glados: Move selects from Kconfig.name to Kconfig
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Should we request the opinion of other Googlers or can this be submitted?
I'll add a few other folks.
However, different mainboards tend to do it different ways, e.g. the ARM google boards look like https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60060
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifccf2b3521d84f6a678872bbccf9bf390c25ce37
Gerrit-Change-Number: 60060
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 15 Dec 2021 21:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment