Change in coreboot[master]: mb/google/dedede/var/metaknight: Generate SPD ID for supported parts
Hello Tim Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/46810
to review the following change.
Change subject: mb/google/dedede/var/metaknight: Generate SPD ID for supported parts ......................................................................
mb/google/dedede/var/metaknight: Generate SPD ID for supported parts
Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the parts. The memory part being added is: MT53E512M32D2NP-046 WT:E K4U6E3S4AA-MGCR H9HCNNNBKMMLXR-NEE MT53E1G32D2NP-046 WT:A K4UBE3D4AA-MGCR
BUG=b:169813211 TEST=Build the metaknight board.
Change-Id: I0d0d22f4790f66b5265803e4dcf01234a16b1993 --- M src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc M src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt 3 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/46810/1
diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc b/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc index b0ca222..285df73 100644 --- a/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc @@ -1,5 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE +SPD_SOURCES += lp4x-spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A +SPD_SOURCES += lp4x-spd-3.hex # ID = 2(0b0010) Parts = K4UBE3D4AA-MGCR diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt index fa24790..100c322 100644 --- a/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt @@ -1 +1,6 @@ DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +K4U6E3S4AA-MGCR 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) +MT53E1G32D2NP-046 WT:A 1 (0001) +K4UBE3D4AA-MGCR 2 (0010) diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt index 59381dc..f05a5af 100644 --- a/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt @@ -1,6 +1,5 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name +MT53E512M32D2NP-046 WT:E +K4U6E3S4AA-MGCR +H9HCNNNBKMMLXR-NEE +MT53E1G32D2NP-046 WT:A +K4UBE3D4AA-MGCR
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Tim Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46810
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/metaknight: Generate SPD ID for supported parts ......................................................................
mb/google/dedede/var/metaknight: Generate SPD ID for supported parts
Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the parts. The memory part being added is: MT53E512M32D2NP-046 WT:E K4U6E3S4AA-MGCR H9HCNNNBKMMLXR-NEE MT53E1G32D2NP-046 WT:A K4UBE3D4AA-MGCR
BUG=b:169813211 TEST=Build the metaknight board.
Signed-off-by: Tim Chen tim-chen@quanta.corp-partner.google.com Change-Id: I0d0d22f4790f66b5265803e4dcf01234a16b1993 --- M src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc M src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt 3 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/46810/2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46810 )
Change subject: mb/google/dedede/var/metaknight: Generate SPD ID for supported parts ......................................................................
Patch Set 2: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46810 )
Change subject: mb/google/dedede/var/metaknight: Generate SPD ID for supported parts ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46810 )
Change subject: mb/google/dedede/var/metaknight: Generate SPD ID for supported parts ......................................................................
mb/google/dedede/var/metaknight: Generate SPD ID for supported parts
Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the parts. The memory part being added is: MT53E512M32D2NP-046 WT:E K4U6E3S4AA-MGCR H9HCNNNBKMMLXR-NEE MT53E1G32D2NP-046 WT:A K4UBE3D4AA-MGCR
BUG=b:169813211 TEST=Build the metaknight board.
Signed-off-by: Tim Chen tim-chen@quanta.corp-partner.google.com Change-Id: I0d0d22f4790f66b5265803e4dcf01234a16b1993 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46810 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc M src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt 3 files changed, 14 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc b/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc index b0ca222..285df73 100644 --- a/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc @@ -1,5 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE +SPD_SOURCES += lp4x-spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A +SPD_SOURCES += lp4x-spd-3.hex # ID = 2(0b0010) Parts = K4UBE3D4AA-MGCR diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt index fa24790..100c322 100644 --- a/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt @@ -1 +1,6 @@ DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +K4U6E3S4AA-MGCR 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) +MT53E1G32D2NP-046 WT:A 1 (0001) +K4UBE3D4AA-MGCR 2 (0010) diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt index 59381dc..f05a5af 100644 --- a/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt @@ -1,6 +1,5 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name +MT53E512M32D2NP-046 WT:E +K4U6E3S4AA-MGCR +H9HCNNNBKMMLXR-NEE +MT53E1G32D2NP-046 WT:A +K4UBE3D4AA-MGCR
-
Karthik Ramasubramanian (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Chen (Code Review)