[XS] Change in coreboot[main]: edid.h: Increase EDID_ASCII_STRING_LENGTH to 14 - coreboot-gerrit

11 Sep 2024


      Attention is currently required from: Elyes Haouas.
Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84277?usp=email )
Change subject: edid.h: Increase EDID_ASCII_STRING_LENGTH to 14
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
The 13 here come from the EDID specification, we should not change it. The panels in src/drivers/mipi don't have real EDIDs, we're just reusing the data structure to have a common interface for display parameters. I think the correct fix here is to just truncate the MIPI panel names in whatever way makes sense to fit in 13 bytes (without terminating '\0').
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84277?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I48196ba7f7cd8520dbf7f62385b7d83012ad617f
Gerrit-Change-Number: 84277
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 11 Sep 2024 20:07:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No