build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52655 )
Change subject: asus/am1i-a: create the correct MP tables ......................................................................
Patch Set 1:
(15 comments)
File src/mainboard/asus/am1i-a/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/579a37d3_f07b4538 PS1, Line 25: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* APU Integrated Graphics: 0:01.00 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/d8cda324_f16de090 PS1, Line 26: {ACTL_DEVFN, {PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC} }, /* APU HDMI Audio Controller: 0:01.01 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/b90ab0bb_25fa0e98 PS1, Line 27: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} }, /* PCIe GPP to dGPU 1:00.00: 0:02.01 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/b0384dab_6afc0a22 PS1, Line 28: {NB_PCIE_PORT5_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A} }, /* PCIe GPP to Eth 2:00.00: 0:02.05 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/4abcc7f4_1c7a5e57 PS1, Line 29: {XHCI_DEVFN, {PIRQ_C, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB XHCI: 0:10.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/68c64c7c_aa3cb39b PS1, Line 30: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* SATA: 0:11.00 - IRQ 7 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/bcf0b2dd_e3d06d51 PS1, Line 31: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI1: 0:12.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/766f1a86_289d1dc6 PS1, Line 32: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC} }, /* USB EHCI1: 0:12.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/06761a3d_20966bfc PS1, Line 33: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI2: 0:13.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/efc17967_aac24aab PS1, Line 34: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC} }, /* USB EHCI2: 0:13.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/0f593d05_1f74c433 PS1, Line 35: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI3: 0:16.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/276b4530_bcddd6aa PS1, Line 36: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC} }, /* USB EHCI3: 0:16.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/6a9b5bbb_b6dce93e PS1, Line 37: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC} } /* Southbridge HD Audio: 0:14.02 - IRQ 3 */ line over 96 characters
File src/mainboard/asus/am1i-a/mptable.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/72e4deeb_c5692bf8 PS1, Line 127: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117713): https://review.coreboot.org/c/coreboot/+/52655/comment/f38a66ad_4f28d971 PS1, Line 173: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters
-
build bot (Jenkins) (Code Review)