Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Tarun, sridhar siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80361?usp=email )
Change subject: soc/intel/cmn/sa: Refactor SA common code ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/alderlake/include/soc/systemagent.h:
https://review.coreboot.org/c/coreboot/+/80361/comment/5409bd8e_53f05b79 : PS2, Line 69: #define MASK_DSM_LENGTH 0xFF00 // [15:8] : #define MASK_DSM_LENGTH_LSB 8 // used to shift right : #define MASK_GSM_LENGTH 0xC0 // [7:6] : #define MASK_GSM_LENGTH_LSB 6 // used to shift right : #define MASK_DPR_LENGTH 0xFF0 // [11:4] : #define MASK_DPR_LENGTH_LSB 4 // used to shift right
Hmm, did you overlook alignment (lines#69, #71, #73)?
Acknowledged
File src/soc/intel/meteorlake/include/soc/systemagent.h:
https://review.coreboot.org/c/coreboot/+/80361/comment/60f185d9_7553728c : PS2, Line 55: #define MASK_DSM_LENGTH 0xFF00 // [15:8] : #define MASK_DSM_LENGTH_LSB 8 // used to shift right : #define MASK_GSM_LENGTH 0xC0 // [7:6] : #define MASK_GSM_LENGTH_LSB 6 // used to shift right : #define MASK_DPR_LENGTH 0xFF0 // [11:4] : #define MASK_DPR_LENGTH_LSB 4 // used to shift right
nit: here too,, alignment issue(lines#55, #57, #59)?
thanks for the review. I thought i have added the correct alignment. may be lost while rebasing.