Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Tarun, sridhar siricilla.
2 comments:
File src/soc/intel/alderlake/include/soc/systemagent.h:
#define MASK_DSM_LENGTH 0xFF00 // [15:8]
#define MASK_DSM_LENGTH_LSB 8 // used to shift right
#define MASK_GSM_LENGTH 0xC0 // [7:6]
#define MASK_GSM_LENGTH_LSB 6 // used to shift right
#define MASK_DPR_LENGTH 0xFF0 // [11:4]
#define MASK_DPR_LENGTH_LSB 4 // used to shift right
Hmm, did you overlook alignment (lines#69, #71, #73)?
Acknowledged
File src/soc/intel/meteorlake/include/soc/systemagent.h:
#define MASK_DSM_LENGTH 0xFF00 // [15:8]
#define MASK_DSM_LENGTH_LSB 8 // used to shift right
#define MASK_GSM_LENGTH 0xC0 // [7:6]
#define MASK_GSM_LENGTH_LSB 6 // used to shift right
#define MASK_DPR_LENGTH 0xFF0 // [11:4]
#define MASK_DPR_LENGTH_LSB 4 // used to shift right
nit: here too,, alignment issue(lines#55, #57, #59)?
thanks for the review. I thought i have added the correct alignment. may be lost while rebasing.
To view, visit change 80361. To unsubscribe, or for help writing mail filters, visit settings.