Attention is currently required from: Patrick Rudolph.
Star Labs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52798 )
Change subject: soc/mainboard: Add Star Labs labtop series
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/starlabs/labtop/Kconfig:
https://review.coreboot.org/c/coreboot/+/52798/comment/011b9452_6decbd16
PS14, Line 26: HAVE_IFD_BIN
resolve commented options
Shall I just remove them? Comments were only added to stop the build failure for this patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37c74d03d86fb124ed96e45d1bf137eb2ec57251
Gerrit-Change-Number: 52798
Gerrit-PatchSet: 14
Gerrit-Owner: Star Labs
admin@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 07 May 2021 06:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment