Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21205 )
Change subject: direct pci: Always initialize Address_State ......................................................................
direct pci: Always initialize Address_State
Let Initialize() always initialize the Address_State. This is not only the expected behaviour but also necessary to share the contract with other implementations.
Change-Id: I0454dfd6c36f7d4298edeec5b84d929e3160eb7b Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/21205 Reviewed-by: Adrian-Ken Rueegsegger ken@codelabs.ch --- M common/direct/hw-pci-dev.adb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Nico Huber: Verified Adrian-Ken Rueegsegger: Looks good to me, approved
diff --git a/common/direct/hw-pci-dev.adb b/common/direct/hw-pci-dev.adb index 9bd7d1d..3d76521 100644 --- a/common/direct/hw-pci-dev.adb +++ b/common/direct/hw-pci-dev.adb @@ -108,6 +108,8 @@ begin if MMConf_Base /= 0 then MM.Set_Base_Address (MMConf_Base); + else + MM.Set_Base_Address (Config.Default_MMConf_Base); end if; Success := MMConf_Base /= 0 or Config.Default_MMConf_Base_Set; end Initialize;