Attention is currently required from: Tarun Tuli, Kangheui Won, Tim Wawrzynczak, Tyler Wang, Nick Vaccaro, Eric Lai.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68660 )
Change subject: mb/google/nissa/var/craask: Add wifi sar table
......................................................................
Patch Set 7:
(4 comments)
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68660/comment/dd9e9fdb_5acafe5f
PS7, Line 23: 16
15?
https://review.coreboot.org/c/coreboot/+/68660/comment/a354c29a_c1b4bd34
PS7, Line 25: UN_USED
UNUSED
File src/mainboard/google/brya/variants/craask/variants.c:
PS7:
Please rename this to `variant.c`
https://review.coreboot.org/c/coreboot/+/68660/comment/65e95f38_51df45e8
PS7, Line 19: WIFI_SAR_CBFS_DEFAULT_FILENAME
This file won't exist. Maybe return NULL by default instead? This function shouldn't be called for devices without Intel wifi anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c92f0ab53ece12a97068f09241e5298909116aa
Gerrit-Change-Number: 68660
Gerrit-PatchSet: 7
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cathy Chen
cathy_chen@quanta.corp-partner.google.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 07 Nov 2022 00:18:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment