Attention is currently required from: Hsuan Ting Chen, Nico Huber, Subrata Banik, Hsuan-ting Chen.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73099 )
Change subject: vga: Change the arguments of vga_write_text to support extended ASCII
......................................................................
Patch Set 3:
(1 comment)
File src/include/pc80/vga.h:
https://review.coreboot.org/c/coreboot/+/73099/comment/960f4184_e0057dc2
PS1, Line 36: void vga_write_text(enum VGA_TEXT_ALIGNMENT alignment, unsigned int line, const char *string);
I was hesitate to change the arguments is because this will reject using string literal as: […]
Ahh yes - makes sense.
I'd personally prefer the cast rather than a different function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If555bbc05f40ce3f02339c0468afff6dda8b7ded
Gerrit-Change-Number: 73099
Gerrit-PatchSet: 3
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Comment-Date: Tue, 21 Feb 2023 17:09:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Gerrit-MessageType: comment