Change in coreboot[master]: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ......................................................................
Patch Set 4: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56171/comment/9827ca37_ad5522b6 PS4, Line 9: Tiger Lake nit: Tiger Lake LP
File util/inteltool/gpio_names/tigerlake.h:
PS4: Hmmm, shouldn't this have a license? Looks like other headers in gpio_names don't have a license either.
https://review.coreboot.org/c/coreboot/+/56171/comment/8a5c8e42_5cc78f8e PS4, Line 70: nit: drop blank line
https://review.coreboot.org/c/coreboot/+/56171/comment/d2129a3c_f970422c PS4, Line 300: /* : * GPP_A group does not start right after GPP_T group and GPP_T group does not : * start right after GPP_B. Fill the holes with Reserved on both sides. : */ Well, to me it looks like some GPP_T GPIOs are undocumented.
https://review.coreboot.org/c/coreboot/+/56171/comment/5988c3d9_221fea2e PS4, Line 777: nit: drop blank line
File util/inteltool/pcr.c:
https://review.coreboot.org/c/coreboot/+/56171/comment/02fba84a_e45be75e PS4, Line 108: case PCI_DEVICE_ID_INTEL_Q570: : case PCI_DEVICE_ID_INTEL_Z590: : case PCI_DEVICE_ID_INTEL_H570: : case PCI_DEVICE_ID_INTEL_B560: : case PCI_DEVICE_ID_INTEL_H510: : case PCI_DEVICE_ID_INTEL_WM590: : case PCI_DEVICE_ID_INTEL_QM580: : case PCI_DEVICE_ID_INTEL_HM570: : case PCI_DEVICE_ID_INTEL_C252: : case PCI_DEVICE_ID_INTEL_C256: : case PCI_DEVICE_ID_INTEL_W580: TGL-H should be handled the same way as TGL-LP
-
Angel Pons (Code Review)