Raymond Chung has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39271 )
Change subject: mb/google/hatch: Add LP_4G_2133 SPD ......................................................................
mb/google/hatch: Add LP_4G_2133 SPD
Add LPDDR3 4GB 2133MHz SPD file.
BUG=b:149226871 TEST=Build and check cbfs has the spd.bin
Change-Id: I1598774a87eecc76082286540beadaa3c26eda69 Signed-off-by: Raymond Chung raymondchung@ami.corp-partner.google.com --- A src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex 1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/39271/1
diff --git a/src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex b/src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex new file mode 100644 index 0000000..fc7b9c8 --- /dev/null +++ b/src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex @@ -0,0 +1,32 @@ +24 20 0F 0E 15 19 01 08 00 00 00 0B 03 03 00 00 +00 00 08 FF D4 01 00 00 78 00 90 A8 90 90 06 D0 +02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 08 7F C2 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39271 )
Change subject: mb/google/hatch: Add LP_4G_2133 SPD for Nightfury ......................................................................
Patch Set 5:
This change is ready for review.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39271 )
Change subject: mb/google/hatch: Add LP_4G_2133 SPD for Nightfury ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG@7 PS5, Line 7: for Nightfury Remove this. This is not specific to a particular variant. It just happens to be used by Nightfury at the moment.
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG@9 PS5, Line 9: for Nightfury. Same here.
https://review.coreboot.org/c/coreboot/+/39271/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39271/5/src/mainboard/google/hatch/... PS5, Line 17: SPD_SOURCES += LP_4G_2133 # 0b010 Let's move this into https://review.coreboot.org/c/coreboot/+/38826 and rebase so that this CL gets submitted first. This CL is not specific to Nightfury.
Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Philip Chen, Bob Moragues, Bob Moragues, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39271
to look at the new patch set (#6).
Change subject: mb/google/hatch: Add LP_4G_2133 SPD ......................................................................
mb/google/hatch: Add LP_4G_2133 SPD
Add LPDDR3 4GB 2133MHz SPD file.
BUG=b:149226871 TEST=Build and check cbfs has the spd.bin
Change-Id: I1598774a87eecc76082286540beadaa3c26eda69 Signed-off-by: Raymond Chung raymondchung@ami.corp-partner.google.com --- A src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex 1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/39271/6
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39271 )
Change subject: mb/google/hatch: Add LP_4G_2133 SPD ......................................................................
Patch Set 8: Code-Review+2
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39271 )
Change subject: mb/google/hatch: Add LP_4G_2133 SPD ......................................................................
Patch Set 8: Code-Review+2
Can we merge?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39271 )
Change subject: mb/google/hatch: Add LP_4G_2133 SPD ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG@7 PS5, Line 7: for Nightfury
Remove this. This is not specific to a particular variant. […]
Done
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG@9 PS5, Line 9: for Nightfury.
Same here.
Done
https://review.coreboot.org/c/coreboot/+/39271/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/nightfury/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39271/5/src/mainboard/google/hatch/... PS5, Line 17: SPD_SOURCES += LP_4G_2133 # 0b010
Let's move this into https://review.coreboot. […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39271 )
Change subject: mb/google/hatch: Add LP_4G_2133 SPD ......................................................................
mb/google/hatch: Add LP_4G_2133 SPD
Add LPDDR3 4GB 2133MHz SPD file.
BUG=b:149226871 TEST=Build and check cbfs has the spd.bin
Change-Id: I1598774a87eecc76082286540beadaa3c26eda69 Signed-off-by: Raymond Chung raymondchung@ami.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39271 Reviewed-by: Shelley Chen shchen@google.com Reviewed-by: Philip Chen philipchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex 1 file changed, 32 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Philip Chen: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex b/src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex new file mode 100644 index 0000000..fc7b9c8 --- /dev/null +++ b/src/mainboard/google/hatch/spd/LP_4G_2133.spd.hex @@ -0,0 +1,32 @@ +24 20 0F 0E 15 19 01 08 00 00 00 0B 03 03 00 00 +00 00 08 FF D4 01 00 00 78 00 90 A8 90 90 06 D0 +02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 08 7F C2 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-
Patrick Georgi (Code Review) -
Philip Chen (Code Review)
-
Raymond Chung (Code Review)
-
Shelley Chen (Code Review)