Change in ...coreboot[master]: mainboard/lenovo: remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33901

Change subject: mainboard/lenovo: remove stdlib.h when unused
......................................................................

mainboard/lenovo: remove stdlib.h when unused

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
2 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33901/1

diff --git a/src/mainboard/lenovo/g505s/BiosCallOuts.c b/src/mainboard/lenovo/g505s/BiosCallOuts.c
index 2b1ac04..afa2fce 100644
--- a/src/mainboard/lenovo/g505s/BiosCallOuts.c
+++ b/src/mainboard/lenovo/g505s/BiosCallOuts.c
@@ -16,10 +16,8 @@
 #include <AGESA.h>
 #include <northbridge/amd/agesa/BiosCallOuts.h>
 #include <northbridge/amd/agesa/state_machine.h>
-
 #include <southbridge/amd/agesa/hudson/imc.h>
 #include <vendorcode/amd/agesa/f15tn/Proc/Fch/FchPlatform.h>
-#include <stdlib.h>

const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
diff --git a/src/mainboard/lenovo/g505s/buildOpts.c b/src/mainboard/lenovo/g505s/buildOpts.c
index c3e40ce..559e1a6 100644
--- a/src/mainboard/lenovo/g505s/buildOpts.c
+++ b/src/mainboard/lenovo/g505s/buildOpts.c
@@ -27,8 +27,6 @@

#include "mainboard.h"

-#include <stdlib.h>
-
 #include <vendorcode/amd/agesa/f15tn/AGESA.h>

/*  Include the files that instantiate the configuration definitions.  */
@@ -43,7 +41,6 @@
 #include <vendorcode/amd/agesa/f15tn/Proc/Mem/mm.h>
 #include <vendorcode/amd/agesa/f15tn/Proc/Mem/mn.h>

-
 /*  Select the CPU family.  */
 #define INSTALL_FAMILY_10_SUPPORT FALSE
 #define INSTALL_FAMILY_12_SUPPORT FALSE

Change in coreboot[master]: mainboard/lenovo: Remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33901

to look at the new patch set (#2).

Change subject: mainboard/lenovo: Remove stdlib.h when unused
......................................................................

mainboard/lenovo: Remove stdlib.h when unused

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
2 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33901/2

Change in coreboot[master]: mainboard/lenovo: Remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33901 )

Change subject: mainboard/lenovo: Remove stdlib.h when unused
......................................................................

Abandoned

see 32023

Change in coreboot[master]: mainboard/lenovo: Remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33901 )

Change subject: mainboard/lenovo: Remove stdlib.h when unused
......................................................................

Restored

Change in coreboot[master]: mb/{lenovo,lippert}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33901

to look at the new patch set (#3).

Change subject: mb/{lenovo,lippert}: Remove unused <stdlib.h>
......................................................................

mb/{lenovo,lippert}: Remove unused <stdlib.h>

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
M src/mainboard/lippert/frontrunner-af/BiosCallOuts.c
M src/mainboard/lippert/frontrunner-af/buildOpts.c
M src/mainboard/lippert/frontrunner-af/mainboard.c
M src/mainboard/lippert/frontrunner-af/sema.c
M src/mainboard/lippert/toucan-af/BiosCallOuts.c
M src/mainboard/lippert/toucan-af/buildOpts.c
M src/mainboard/lippert/toucan-af/mainboard.c
9 files changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33901/3

Change in coreboot[master]: mb/{lenovo,lippert}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33901

to look at the new patch set (#5).

Change subject: mb/{lenovo,lippert}: Remove unused <stdlib.h>
......................................................................

mb/{lenovo,lippert}: Remove unused <stdlib.h>

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
M src/mainboard/lippert/frontrunner-af/BiosCallOuts.c
M src/mainboard/lippert/frontrunner-af/buildOpts.c
M src/mainboard/lippert/frontrunner-af/mainboard.c
M src/mainboard/lippert/frontrunner-af/sema.c
M src/mainboard/lippert/toucan-af/BiosCallOuts.c
M src/mainboard/lippert/toucan-af/buildOpts.c
M src/mainboard/lippert/toucan-af/mainboard.c
9 files changed, 0 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33901/5

Change in coreboot[master]: mb/{lenovo,lippert}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33901

to look at the new patch set (#7).

Change subject: mb/{lenovo,lippert}: Remove unused <stdlib.h>
......................................................................

mb/{lenovo,lippert}: Remove unused <stdlib.h>

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
D src/mainboard/lippert/Kconfig
D src/mainboard/lippert/Kconfig.name
4 files changed, 0 insertions(+), 25 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33901/7

Change in coreboot[master]: mb/{lenovo,lippert}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33901

to look at the new patch set (#8).

Change subject: mb/{lenovo,lippert}: Remove unused <stdlib.h>
......................................................................

mb/{lenovo,lippert}: Remove unused <stdlib.h>

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33901/8

Change in coreboot[master]: mb/lippert/g505s: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33901

to look at the new patch set (#9).

Change subject: mb/lippert/g505s: Remove unused <stdlib.h>
......................................................................

mb/lippert/g505s: Remove unused <stdlib.h>

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33901/9

Change in coreboot[master]: mb/lenovo/g505s: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded a new patch set (#10) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/33901 )

Change subject: mb/lenovo/g505s: Remove unused <stdlib.h>
......................................................................

mb/lenovo/g505s: Remove unused <stdlib.h>

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/33901/10

Change in coreboot[master]: mb/lenovo/g505s: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33901 )

Change subject: mb/lenovo/g505s: Remove unused <stdlib.h>
......................................................................

Patch Set 10: Code-Review+2

Change in coreboot[master]: mb/lenovo/g505s: Remove unused <stdlib.h>

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33901 )

Change subject: mb/lenovo/g505s: Remove unused <stdlib.h>
......................................................................

Patch Set 12: Code-Review+2

Change in coreboot[master]: mb/lenovo/g505s: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33901 )

Change subject: mb/lenovo/g505s: Remove unused <stdlib.h>
......................................................................

mb/lenovo/g505s: Remove unused <stdlib.h>

Change-Id: I6af1d44f9a05c153b6a355318a39adc9a3d6c0c9
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33901
Reviewed-by: Werner Zeh 
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/lenovo/g505s/BiosCallOuts.c
M src/mainboard/lenovo/g505s/buildOpts.c
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Werner Zeh: Looks good to me, approved

diff --git a/src/mainboard/lenovo/g505s/BiosCallOuts.c b/src/mainboard/lenovo/g505s/BiosCallOuts.c
index 2b1ac04..f36e11e 100644
--- a/src/mainboard/lenovo/g505s/BiosCallOuts.c
+++ b/src/mainboard/lenovo/g505s/BiosCallOuts.c
@@ -19,7 +19,6 @@

#include <southbridge/amd/agesa/hudson/imc.h>
 #include <vendorcode/amd/agesa/f15tn/Proc/Fch/FchPlatform.h>
-#include <stdlib.h>

const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
diff --git a/src/mainboard/lenovo/g505s/buildOpts.c b/src/mainboard/lenovo/g505s/buildOpts.c
index c3e40ce..3adf20d9 100644
--- a/src/mainboard/lenovo/g505s/buildOpts.c
+++ b/src/mainboard/lenovo/g505s/buildOpts.c
@@ -27,7 +27,6 @@

#include "mainboard.h"

-#include <stdlib.h>

#include <vendorcode/amd/agesa/f15tn/AGESA.h>