HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45102 )
Change subject: mb/prodrive/hermes: Clean-up Kconfig ......................................................................
mb/prodrive/hermes: Clean-up Kconfig
This fix 'util/lint/kconfig_lint' warning: 'Warning: Unused symbol 'BOARD_PRODRIVE_HERMES' referenced at src/mainboard/prodrive/hermes/Kconfig.name:1'
Change-Id: I6d80a52b374fa4c6f665b42bdf3591fb87238525 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/prodrive/hermes/Kconfig M src/mainboard/prodrive/hermes/Kconfig.name 2 files changed, 6 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/45102/1
diff --git a/src/mainboard/prodrive/hermes/Kconfig b/src/mainboard/prodrive/hermes/Kconfig index 6a79f5b..366f7fd 100644 --- a/src/mainboard/prodrive/hermes/Kconfig +++ b/src/mainboard/prodrive/hermes/Kconfig @@ -1,5 +1,7 @@ -config BOARD_PRODRIVE_HERMES_BASEBOARD - def_bool n +if BOARD_PRODRIVE_HERMES + +config BOARD_SPECIFIC_OPTIONS + def_bool y select SOC_INTEL_COFFEELAKE select BOARD_ROMSIZE_KB_32768 select GENERIC_SPD_BIN @@ -19,8 +21,6 @@ select ONBOARD_VGA_IS_PRIMARY select DISABLE_ACPI_HIBERNATE
-if BOARD_PRODRIVE_HERMES_BASEBOARD - config MAINBOARD_FAMILY string default "PRODRIVE_HERMES_SERIES" @@ -43,7 +43,7 @@
config VARIANT_DIR string - default "baseboard" if BOARD_PRODRIVE_HERMES_BASEBOARD + default "baseboard" if BOARD_PRODRIVE_HERMES
config MAX_CPUS int @@ -69,4 +69,4 @@ hex default 0x900000
-endif # BOARD_PRODRIVE_HERMES_BASEBOARD +endif # BOARD_PRODRIVE_HERMES diff --git a/src/mainboard/prodrive/hermes/Kconfig.name b/src/mainboard/prodrive/hermes/Kconfig.name index 10dd9ba..4aff62f 100644 --- a/src/mainboard/prodrive/hermes/Kconfig.name +++ b/src/mainboard/prodrive/hermes/Kconfig.name @@ -1,3 +1,2 @@ config BOARD_PRODRIVE_HERMES bool "Hermes" - select BOARD_PRODRIVE_HERMES_BASEBOARD
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45102 )
Change subject: mb/prodrive/hermes: Clean-up Kconfig ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45102/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45102/1//COMMIT_MSG@7 PS1, Line 7: Clean-up Clean up
https://review.coreboot.org/c/coreboot/+/45102/1//COMMIT_MSG@7 PS1, Line 7: mb/prodrive/hermes: Clean-up Kconfig Maybe:
Refactor Kconfig to avoid unused symbol warning
https://review.coreboot.org/c/coreboot/+/45102/1//COMMIT_MSG@9 PS1, Line 9: fix fixes
Hello build bot (Jenkins), Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45102
to look at the new patch set (#2).
Change subject: mb/prodrive/hermes: Refactor Kconfig to avoid unused symbol warning ......................................................................
mb/prodrive/hermes: Refactor Kconfig to avoid unused symbol warning
This fixes 'util/lint/kconfig_lint' warning: 'Warning: Unused symbol 'BOARD_PRODRIVE_HERMES' referenced at src/mainboard/prodrive/hermes/Kconfig.name:1'
Change-Id: I6d80a52b374fa4c6f665b42bdf3591fb87238525 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/prodrive/hermes/Kconfig M src/mainboard/prodrive/hermes/Kconfig.name 2 files changed, 6 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/45102/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45102 )
Change subject: mb/prodrive/hermes: Refactor Kconfig to avoid unused symbol warning ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45102/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45102/1//COMMIT_MSG@7 PS1, Line 7: mb/prodrive/hermes: Clean-up Kconfig
Maybe: […]
Thx
https://review.coreboot.org/c/coreboot/+/45102/1//COMMIT_MSG@7 PS1, Line 7: Clean-up
Clean up
Done
https://review.coreboot.org/c/coreboot/+/45102/1//COMMIT_MSG@9 PS1, Line 9: fix
fixes
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45102 )
Change subject: mb/prodrive/hermes: Refactor Kconfig to avoid unused symbol warning ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45102 )
Change subject: mb/prodrive/hermes: Refactor Kconfig to avoid unused symbol warning ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45102/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45102/3//COMMIT_MSG@10 PS3, Line 10: 'Warning: Unused symbol 'BOARD_PRODRIVE_HERMES' referenced at src/mainboard/prodrive/hermes/Kconfig.name:1' If it worked already and this refactoring gets rid of the warning, it wasn't unused and the warning is spurious.
Please fix the check instead. I'm very tired of code changes due to broken warnings.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45102 )
Change subject: mb/prodrive/hermes: Refactor Kconfig to avoid unused symbol warning ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
What this change effectively avoids is the actual problem: broken warnings.
https://review.coreboot.org/c/coreboot/+/45102/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45102/3//COMMIT_MSG@10 PS3, Line 10: 'Warning: Unused symbol 'BOARD_PRODRIVE_HERMES' referenced at src/mainboard/prodrive/hermes/Kconfig.name:1'
If it worked already and this refactoring gets rid of the warning, […]
I 100% agree. The linter complains on all sorts of symbols that aren't used as `CONFIG_` somewhere, and all those warnings are just noise.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45102 )
Change subject: mb/prodrive/hermes: Refactor Kconfig to avoid unused symbol warning ......................................................................
Abandoned
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)