HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35996 )
Change subject: src: Remove unused include <device/smbus.h> ......................................................................
src: Remove unused include <device/smbus.h>
Change-Id: Ic8a28493c386c0097dbf3478e6d046fdfbf28724 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/i2c_bus.c M src/device/smbus_ops.c M src/drivers/i2c/adm1026/adm1026.c M src/drivers/i2c/adm1027/adm1027.c M src/drivers/i2c/adt7463/adt7463.c M src/drivers/i2c/at24rf08c/at24rf08c.c M src/drivers/i2c/at24rf08c/lenovo_serials.c M src/drivers/i2c/ck505/ck505.c M src/drivers/i2c/i2cmux/i2cmux.c M src/drivers/i2c/i2cmux2/i2cmux2.c M src/drivers/i2c/lm63/lm63.c M src/drivers/i2c/pcf8523/pcf8523.c M src/drivers/i2c/rtd2132/rtd2132.c M src/drivers/i2c/w83793/w83793.c M src/drivers/i2c/w83795/w83795.c M src/soc/amd/picasso/sm.c M src/soc/amd/stoneyridge/sm.c M src/soc/intel/broadwell/smbus.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/fsp_broadwell_de/smbus.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/amd8111/acpi.c M src/southbridge/amd/amd8111/smbus.c M src/southbridge/amd/cimx/sb800/late.c M src/southbridge/amd/cimx/sb900/late.c M src/southbridge/amd/pi/hudson/sm.c M src/southbridge/amd/sb700/sm.c M src/southbridge/amd/sb800/sm.c M src/southbridge/broadcom/bcm5785/sb_pci_main.c M src/southbridge/intel/bd82x6x/smbus.c M src/southbridge/intel/fsp_rangeley/smbus.c M src/southbridge/intel/i82371eb/smbus.c M src/southbridge/intel/i82801gx/smbus.c M src/southbridge/intel/i82801ix/smbus.c M src/southbridge/intel/i82801jx/smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/smbus.c M src/southbridge/nvidia/ck804/nic.c M src/southbridge/nvidia/ck804/smbus.c M src/southbridge/nvidia/mcp55/nic.c M src/southbridge/nvidia/mcp55/smbus.c M src/superio/renesas/m3885x/superio.c M src/superio/smsc/dme1737/superio.c M src/superio/smsc/kbc1100/superio.c M src/superio/smsc/lpc47b272/superio.c M src/superio/smsc/lpc47b397/superio.c M src/superio/smsc/lpc47m10x/superio.c M src/superio/smsc/lpc47m15x/superio.c M src/superio/smsc/lpc47n217/superio.c M src/superio/smsc/lpc47n227/superio.c M src/superio/smsc/mec1308/superio.c 51 files changed, 0 insertions(+), 51 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/35996/1
diff --git a/src/device/i2c_bus.c b/src/device/i2c_bus.c index 93634d2..8a739ed 100644 --- a/src/device/i2c_bus.c +++ b/src/device/i2c_bus.c @@ -14,7 +14,6 @@ #include <stdlib.h> #include <stdint.h> #include <console/console.h> -#include <device/smbus.h> #include <device/i2c_bus.h> #include <commonlib/endian.h>
diff --git a/src/device/smbus_ops.c b/src/device/smbus_ops.c index 13e6cad..507606e 100644 --- a/src/device/smbus_ops.c +++ b/src/device/smbus_ops.c @@ -14,7 +14,6 @@ #include <stdint.h> #include <console/console.h> #include <device/device.h> -#include <device/smbus.h>
struct bus *get_pbus_smbus(struct device *dev) { diff --git a/src/drivers/i2c/adm1026/adm1026.c b/src/drivers/i2c/adm1026/adm1026.c index 0a3ac8d..dd15845 100644 --- a/src/drivers/i2c/adm1026/adm1026.c +++ b/src/drivers/i2c/adm1026/adm1026.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/smbus.h>
#define ADM1026_DEVICE 0x2d /* Either 0x2c or 0x2d or 0x2e */ #define ADM1026_REG_CONFIG1 0x00 diff --git a/src/drivers/i2c/adm1027/adm1027.c b/src/drivers/i2c/adm1027/adm1027.c index 375b292..c588284 100644 --- a/src/drivers/i2c/adm1027/adm1027.c +++ b/src/drivers/i2c/adm1027/adm1027.c @@ -1,6 +1,5 @@ #include <console/console.h> #include <device/device.h> -#include <device/smbus.h>
#define ADM1027_REG_CONFIG1 0x40 #define CFG1_STRT 0x01 diff --git a/src/drivers/i2c/adt7463/adt7463.c b/src/drivers/i2c/adt7463/adt7463.c index 93c6f19..529956b 100644 --- a/src/drivers/i2c/adt7463/adt7463.c +++ b/src/drivers/i2c/adt7463/adt7463.c @@ -18,7 +18,6 @@
#include <device/device.h> #include <console/console.h> -#include <device/smbus.h>
/** * Do some S2881-specific HWM initialization for the ADT7463 chip. diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c index 67760a0..afe5ae6 100644 --- a/src/drivers/i2c/at24rf08c/at24rf08c.c +++ b/src/drivers/i2c/at24rf08c/at24rf08c.c @@ -15,7 +15,6 @@
#include <types.h> #include <device/device.h> -#include <device/smbus.h> #include <smbios.h> #include <console/console.h>
diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c index 0a6b343..ec32324 100644 --- a/src/drivers/i2c/at24rf08c/lenovo_serials.c +++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c @@ -16,7 +16,6 @@ #include <types.h> #include <string.h> #include <device/device.h> -#include <device/smbus.h> #include <smbios.h> #include <console/console.h> #include <version.h> diff --git a/src/drivers/i2c/ck505/ck505.c b/src/drivers/i2c/ck505/ck505.c index b368d81..67ec3db 100644 --- a/src/drivers/i2c/ck505/ck505.c +++ b/src/drivers/i2c/ck505/ck505.c @@ -17,7 +17,6 @@ #include <assert.h> #include <console/console.h> #include <device/device.h> -#include <device/smbus.h> #include "chip.h"
#define SMBUS_BLOCK_SIZE 32 diff --git a/src/drivers/i2c/i2cmux/i2cmux.c b/src/drivers/i2c/i2cmux/i2cmux.c index ef5ab3a..e82e298 100644 --- a/src/drivers/i2c/i2cmux/i2cmux.c +++ b/src/drivers/i2c/i2cmux/i2cmux.c @@ -1,5 +1,4 @@ #include <device/device.h> -#include <device/smbus.h>
static void i2cmux_set_link(struct device *dev, unsigned int link) { diff --git a/src/drivers/i2c/i2cmux2/i2cmux2.c b/src/drivers/i2c/i2cmux2/i2cmux2.c index 4d1241a..6f8dc82 100644 --- a/src/drivers/i2c/i2cmux2/i2cmux2.c +++ b/src/drivers/i2c/i2cmux2/i2cmux2.c @@ -1,5 +1,4 @@ #include <device/device.h> -#include <device/smbus.h>
static void i2cmux2_set_link(struct device *dev, unsigned int link) { diff --git a/src/drivers/i2c/lm63/lm63.c b/src/drivers/i2c/lm63/lm63.c index 5ef70cb..2637174 100644 --- a/src/drivers/i2c/lm63/lm63.c +++ b/src/drivers/i2c/lm63/lm63.c @@ -1,5 +1,4 @@ #include <device/device.h> -#include <device/smbus.h>
static void lm63_init(struct device *dev) { diff --git a/src/drivers/i2c/pcf8523/pcf8523.c b/src/drivers/i2c/pcf8523/pcf8523.c index 2da8be2..8e3cbf8 100644 --- a/src/drivers/i2c/pcf8523/pcf8523.c +++ b/src/drivers/i2c/pcf8523/pcf8523.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <device/smbus.h> #include <version.h> #include <console/console.h> #include <bcd.h> diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c index 2aaa234..367ff88 100644 --- a/src/drivers/i2c/rtd2132/rtd2132.c +++ b/src/drivers/i2c/rtd2132/rtd2132.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <delay.h> #include <device/device.h> -#include <device/smbus.h> #include <device/pci.h> #include "chip.h"
diff --git a/src/drivers/i2c/w83793/w83793.c b/src/drivers/i2c/w83793/w83793.c index 8b8f3d2..77efd85 100644 --- a/src/drivers/i2c/w83793/w83793.c +++ b/src/drivers/i2c/w83793/w83793.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <device/device.h> #include "w83793.h" -#include <device/smbus.h> #include "chip.h"
static int w83793_fan_limit(struct device *dev, int fan, uint16_t limit) diff --git a/src/drivers/i2c/w83795/w83795.c b/src/drivers/i2c/w83795/w83795.c index 6869636..8dab027 100644 --- a/src/drivers/i2c/w83795/w83795.c +++ b/src/drivers/i2c/w83795/w83795.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include "w83795.h" -#include <device/smbus.h> #include "chip.h"
static int w83795_set_bank(struct device *dev, uint8_t bank) diff --git a/src/soc/amd/picasso/sm.c b/src/soc/amd/picasso/sm.c index 803e628..bf82085 100644 --- a/src/soc/amd/picasso/sm.c +++ b/src/soc/amd/picasso/sm.c @@ -17,7 +17,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> -#include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> #include <stdlib.h> diff --git a/src/soc/amd/stoneyridge/sm.c b/src/soc/amd/stoneyridge/sm.c index fbcddfa..f14b7af 100644 --- a/src/soc/amd/stoneyridge/sm.c +++ b/src/soc/amd/stoneyridge/sm.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> #include <stdlib.h> diff --git a/src/soc/intel/broadwell/smbus.c b/src/soc/intel/broadwell/smbus.c index 9367f33..123468b 100644 --- a/src/soc/intel/broadwell/smbus.c +++ b/src/soc/intel/broadwell/smbus.c @@ -17,7 +17,6 @@ #include <arch/io.h> #include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/smbus_def.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c index 77b05c1..a388e6b 100644 --- a/src/soc/intel/common/block/smbus/smbus.c +++ b/src/soc/intel/common/block/smbus/smbus.c @@ -16,7 +16,6 @@ #include <arch/io.h> #include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <soc/smbus.h> diff --git a/src/soc/intel/fsp_broadwell_de/smbus.c b/src/soc/intel/fsp_broadwell_de/smbus.c index 94474f7..1262e33 100644 --- a/src/soc/intel/fsp_broadwell_de/smbus.c +++ b/src/soc/intel/fsp_broadwell_de/smbus.c @@ -17,7 +17,6 @@
#include <arch/io.h> #include <device/device.h> -#include <device/smbus.h> #include <device/smbus_def.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/amd/agesa/hudson/sm.c b/src/southbridge/amd/agesa/hudson/sm.c index b5739f9..d78c311 100644 --- a/src/southbridge/amd/agesa/hudson/sm.c +++ b/src/southbridge/amd/agesa/hudson/sm.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> #include <stdlib.h> diff --git a/src/southbridge/amd/amd8111/acpi.c b/src/southbridge/amd/amd8111/acpi.c index ab48833..794a945 100644 --- a/src/southbridge/amd/amd8111/acpi.c +++ b/src/southbridge/amd/amd8111/acpi.c @@ -16,7 +16,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> -#include <device/smbus.h> #include <pc80/mc146818rtc.h> #include <lib.h> #include <arch/io.h> diff --git a/src/southbridge/amd/amd8111/smbus.c b/src/southbridge/amd/amd8111/smbus.c index aa580fe..04005ee 100644 --- a/src/southbridge/amd/amd8111/smbus.c +++ b/src/southbridge/amd/amd8111/smbus.c @@ -17,7 +17,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> -#include <device/smbus.h> #include "amd8111.h"
diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c index 4233a6f..2845553 100644 --- a/src/southbridge/amd/cimx/sb800/late.c +++ b/src/southbridge/amd/cimx/sb800/late.c @@ -22,7 +22,6 @@ #include <device/pci_ids.h> #include <bootstate.h> #include <arch/ioapic.h> -#include <device/smbus.h> /* smbus_bus_operations */ #include <pc80/mc146818rtc.h> #include <pc80/i8254.h> #include <pc80/i8259.h> diff --git a/src/southbridge/amd/cimx/sb900/late.c b/src/southbridge/amd/cimx/sb900/late.c index 3a65e33..30f4949 100644 --- a/src/southbridge/amd/cimx/sb900/late.c +++ b/src/southbridge/amd/cimx/sb900/late.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> /* device_operations */ #include <device/pci_ids.h> -#include <device/smbus.h> /* smbus_bus_operations */ #include <pc80/mc146818rtc.h> #include <pc80/i8254.h> #include <pc80/i8259.h> diff --git a/src/southbridge/amd/pi/hudson/sm.c b/src/southbridge/amd/pi/hudson/sm.c index 58f5113..09dd656 100644 --- a/src/southbridge/amd/pi/hudson/sm.c +++ b/src/southbridge/amd/pi/hudson/sm.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/smbus.h> #include <cpu/x86/lapic.h> #include <arch/ioapic.h> #include <stdlib.h> diff --git a/src/southbridge/amd/sb700/sm.c b/src/southbridge/amd/sb700/sm.c index 6631682..740fe6e 100644 --- a/src/southbridge/amd/sb700/sm.c +++ b/src/southbridge/amd/sb700/sm.c @@ -19,7 +19,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> -#include <device/smbus.h> #include <pc80/mc146818rtc.h> #include <arch/io.h> #include <cpu/x86/lapic.h> diff --git a/src/southbridge/amd/sb800/sm.c b/src/southbridge/amd/sb800/sm.c index 1d2daed8..6db13f1 100644 --- a/src/southbridge/amd/sb800/sm.c +++ b/src/southbridge/amd/sb800/sm.c @@ -18,7 +18,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> -#include <device/smbus.h> #include <pc80/mc146818rtc.h> #include <arch/io.h> #include <cpu/x86/lapic.h> diff --git a/src/southbridge/broadcom/bcm5785/sb_pci_main.c b/src/southbridge/broadcom/bcm5785/sb_pci_main.c index 318086e..8853708 100644 --- a/src/southbridge/broadcom/bcm5785/sb_pci_main.c +++ b/src/southbridge/broadcom/bcm5785/sb_pci_main.c @@ -21,7 +21,6 @@ #include <pc80/mc146818rtc.h> #include <pc80/isa-dma.h> #include <arch/io.h> -#include <device/smbus.h> #include "bcm5785.h" #include "smbus.h"
diff --git a/src/southbridge/intel/bd82x6x/smbus.c b/src/southbridge/intel/bd82x6x/smbus.c index 4fb7539..1aeb1ed 100644 --- a/src/southbridge/intel/bd82x6x/smbus.c +++ b/src/southbridge/intel/bd82x6x/smbus.c @@ -16,7 +16,6 @@
#include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/intel/fsp_rangeley/smbus.c b/src/southbridge/intel/fsp_rangeley/smbus.c index 610ce0c..50ee07b 100644 --- a/src/southbridge/intel/fsp_rangeley/smbus.c +++ b/src/southbridge/intel/fsp_rangeley/smbus.c @@ -16,7 +16,6 @@
#include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <southbridge/intel/common/smbus.h> diff --git a/src/southbridge/intel/i82371eb/smbus.c b/src/southbridge/intel/i82371eb/smbus.c index 36a9f56..238af72 100644 --- a/src/southbridge/intel/i82371eb/smbus.c +++ b/src/southbridge/intel/i82371eb/smbus.c @@ -24,7 +24,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/smbus.h> #include <southbridge/intel/common/smbus.h> #include "chip.h" #include "i82371eb.h" diff --git a/src/southbridge/intel/i82801gx/smbus.c b/src/southbridge/intel/i82801gx/smbus.c index b2341a1..e7d3bd6 100644 --- a/src/southbridge/intel/i82801gx/smbus.c +++ b/src/southbridge/intel/i82801gx/smbus.c @@ -16,7 +16,6 @@
#include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <southbridge/intel/common/smbus.h> diff --git a/src/southbridge/intel/i82801ix/smbus.c b/src/southbridge/intel/i82801ix/smbus.c index 9bab9b2..66b27aa 100644 --- a/src/southbridge/intel/i82801ix/smbus.c +++ b/src/southbridge/intel/i82801ix/smbus.c @@ -16,7 +16,6 @@
#include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/intel/i82801jx/smbus.c b/src/southbridge/intel/i82801jx/smbus.c index d366703..925a13b 100644 --- a/src/southbridge/intel/i82801jx/smbus.c +++ b/src/southbridge/intel/i82801jx/smbus.c @@ -16,7 +16,6 @@
#include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/intel/ibexpeak/smbus.c b/src/southbridge/intel/ibexpeak/smbus.c index dd3abfe..9e9c5d5 100644 --- a/src/southbridge/intel/ibexpeak/smbus.c +++ b/src/southbridge/intel/ibexpeak/smbus.c @@ -16,7 +16,6 @@
#include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/intel/lynxpoint/smbus.c b/src/southbridge/intel/lynxpoint/smbus.c index c12b29e..678d0c4 100644 --- a/src/southbridge/intel/lynxpoint/smbus.c +++ b/src/southbridge/intel/lynxpoint/smbus.c @@ -16,7 +16,6 @@
#include <device/device.h> #include <device/path.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/nvidia/ck804/nic.c b/src/southbridge/nvidia/ck804/nic.c index 5dbb6b4..cac7c8d 100644 --- a/src/southbridge/nvidia/ck804/nic.c +++ b/src/southbridge/nvidia/ck804/nic.c @@ -15,7 +15,6 @@ */
#include <device/device.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/nvidia/ck804/smbus.c b/src/southbridge/nvidia/ck804/smbus.c index b96dc6e..dc2777b 100644 --- a/src/southbridge/nvidia/ck804/smbus.c +++ b/src/southbridge/nvidia/ck804/smbus.c @@ -17,7 +17,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/smbus.h> #include "chip.h" #include "smbus.h"
diff --git a/src/southbridge/nvidia/mcp55/nic.c b/src/southbridge/nvidia/mcp55/nic.c index af4df44..3657a77 100644 --- a/src/southbridge/nvidia/mcp55/nic.c +++ b/src/southbridge/nvidia/mcp55/nic.c @@ -19,7 +19,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/nvidia/mcp55/smbus.c b/src/southbridge/nvidia/mcp55/smbus.c index 37f4a1e..334c8a4 100644 --- a/src/southbridge/nvidia/mcp55/smbus.c +++ b/src/southbridge/nvidia/mcp55/smbus.c @@ -20,7 +20,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/smbus.h> #include "mcp55.h" #include "smbus.h"
diff --git a/src/superio/renesas/m3885x/superio.c b/src/superio/renesas/m3885x/superio.c index 522d647..79d300b 100644 --- a/src/superio/renesas/m3885x/superio.c +++ b/src/superio/renesas/m3885x/superio.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pnp.h> #include <console/console.h> -#include <device/smbus.h> #include <stdlib.h> #include <pc80/keyboard.h>
diff --git a/src/superio/smsc/dme1737/superio.c b/src/superio/smsc/dme1737/superio.c index 0bfd3b8..e463ef3 100644 --- a/src/superio/smsc/dme1737/superio.c +++ b/src/superio/smsc/dme1737/superio.c @@ -19,7 +19,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "dme1737.h" diff --git a/src/superio/smsc/kbc1100/superio.c b/src/superio/smsc/kbc1100/superio.c index e43e791..cd621a4 100644 --- a/src/superio/smsc/kbc1100/superio.c +++ b/src/superio/smsc/kbc1100/superio.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "kbc1100.h" diff --git a/src/superio/smsc/lpc47b272/superio.c b/src/superio/smsc/lpc47b272/superio.c index 6ac2d6d..c4e9fc5 100644 --- a/src/superio/smsc/lpc47b272/superio.c +++ b/src/superio/smsc/lpc47b272/superio.c @@ -22,7 +22,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "lpc47b272.h" diff --git a/src/superio/smsc/lpc47b397/superio.c b/src/superio/smsc/lpc47b397/superio.c index 4b9e345..dc6dde3 100644 --- a/src/superio/smsc/lpc47b397/superio.c +++ b/src/superio/smsc/lpc47b397/superio.c @@ -20,7 +20,6 @@ #include <device/pnp.h> #include <superio/conf_mode.h> #include <console/console.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "lpc47b397.h" diff --git a/src/superio/smsc/lpc47m10x/superio.c b/src/superio/smsc/lpc47m10x/superio.c index cd13854..0cf8324 100644 --- a/src/superio/smsc/lpc47m10x/superio.c +++ b/src/superio/smsc/lpc47m10x/superio.c @@ -21,7 +21,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "lpc47m10x.h" diff --git a/src/superio/smsc/lpc47m15x/superio.c b/src/superio/smsc/lpc47m15x/superio.c index 80ed456..7b7623f 100644 --- a/src/superio/smsc/lpc47m15x/superio.c +++ b/src/superio/smsc/lpc47m15x/superio.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "lpc47m15x.h" diff --git a/src/superio/smsc/lpc47n217/superio.c b/src/superio/smsc/lpc47n217/superio.c index b10e8a1..fe188af 100644 --- a/src/superio/smsc/lpc47n217/superio.c +++ b/src/superio/smsc/lpc47n217/superio.c @@ -23,7 +23,6 @@ #include <device/device.h> #include <device/pnp.h> #include <console/console.h> -#include <device/smbus.h> #include <assert.h> #include <stdlib.h> #include "lpc47n217.h" diff --git a/src/superio/smsc/lpc47n227/superio.c b/src/superio/smsc/lpc47n227/superio.c index 610f685..6fcf8e4 100644 --- a/src/superio/smsc/lpc47n227/superio.c +++ b/src/superio/smsc/lpc47n227/superio.c @@ -19,7 +19,6 @@ #include <device/device.h> #include <device/pnp.h> #include <console/console.h> -#include <device/smbus.h> #include <assert.h> #include <stdlib.h> #include <pc80/keyboard.h> diff --git a/src/superio/smsc/mec1308/superio.c b/src/superio/smsc/mec1308/superio.c index 74b8b2e..2cd9bd3 100644 --- a/src/superio/smsc/mec1308/superio.c +++ b/src/superio/smsc/mec1308/superio.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "mec1308.h"
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35996 )
Change subject: src: Remove unused include <device/smbus.h> ......................................................................
Abandoned
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/35996 )
Change subject: src: Remove unused include <device/smbus.h> ......................................................................
Restored
Hello Patrick Rudolph, Felix Held, Philipp Deppenwiese, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35996
to look at the new patch set (#2).
Change subject: superio: Remove unused include <device/smbus.h> ......................................................................
superio: Remove unused include <device/smbus.h>
Change-Id: Ic8a28493c386c0097dbf3478e6d046fdfbf28724 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/renesas/m3885x/superio.c M src/superio/smsc/kbc1100/superio.c M src/superio/smsc/lpc47m10x/superio.c M src/superio/smsc/lpc47m15x/superio.c M src/superio/smsc/lpc47n217/superio.c M src/superio/smsc/lpc47n227/superio.c M src/superio/smsc/mec1308/superio.c 7 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/35996/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35996 )
Change subject: superio: Remove unused include <device/smbus.h> ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35996 )
Change subject: superio: Remove unused include <device/smbus.h> ......................................................................
superio: Remove unused include <device/smbus.h>
Change-Id: Ic8a28493c386c0097dbf3478e6d046fdfbf28724 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/35996 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/renesas/m3885x/superio.c M src/superio/smsc/kbc1100/superio.c M src/superio/smsc/lpc47m10x/superio.c M src/superio/smsc/lpc47m15x/superio.c M src/superio/smsc/lpc47n217/superio.c M src/superio/smsc/lpc47n227/superio.c M src/superio/smsc/mec1308/superio.c 7 files changed, 0 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/renesas/m3885x/superio.c b/src/superio/renesas/m3885x/superio.c index 522d647..79d300b 100644 --- a/src/superio/renesas/m3885x/superio.c +++ b/src/superio/renesas/m3885x/superio.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pnp.h> #include <console/console.h> -#include <device/smbus.h> #include <stdlib.h> #include <pc80/keyboard.h>
diff --git a/src/superio/smsc/kbc1100/superio.c b/src/superio/smsc/kbc1100/superio.c index e43e791..cd621a4 100644 --- a/src/superio/smsc/kbc1100/superio.c +++ b/src/superio/smsc/kbc1100/superio.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "kbc1100.h" diff --git a/src/superio/smsc/lpc47m10x/superio.c b/src/superio/smsc/lpc47m10x/superio.c index cd13854..0cf8324 100644 --- a/src/superio/smsc/lpc47m10x/superio.c +++ b/src/superio/smsc/lpc47m10x/superio.c @@ -21,7 +21,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "lpc47m10x.h" diff --git a/src/superio/smsc/lpc47m15x/superio.c b/src/superio/smsc/lpc47m15x/superio.c index 80ed456..7b7623f 100644 --- a/src/superio/smsc/lpc47m15x/superio.c +++ b/src/superio/smsc/lpc47m15x/superio.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "lpc47m15x.h" diff --git a/src/superio/smsc/lpc47n217/superio.c b/src/superio/smsc/lpc47n217/superio.c index b10e8a1..fe188af 100644 --- a/src/superio/smsc/lpc47n217/superio.c +++ b/src/superio/smsc/lpc47n217/superio.c @@ -23,7 +23,6 @@ #include <device/device.h> #include <device/pnp.h> #include <console/console.h> -#include <device/smbus.h> #include <assert.h> #include <stdlib.h> #include "lpc47n217.h" diff --git a/src/superio/smsc/lpc47n227/superio.c b/src/superio/smsc/lpc47n227/superio.c index 610f685..6fcf8e4 100644 --- a/src/superio/smsc/lpc47n227/superio.c +++ b/src/superio/smsc/lpc47n227/superio.c @@ -19,7 +19,6 @@ #include <device/device.h> #include <device/pnp.h> #include <console/console.h> -#include <device/smbus.h> #include <assert.h> #include <stdlib.h> #include <pc80/keyboard.h> diff --git a/src/superio/smsc/mec1308/superio.c b/src/superio/smsc/mec1308/superio.c index 74b8b2e..2cd9bd3 100644 --- a/src/superio/smsc/mec1308/superio.c +++ b/src/superio/smsc/mec1308/superio.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/pnp.h> #include <superio/conf_mode.h> -#include <device/smbus.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "mec1308.h"
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)