Attention is currently required from: Furquan Shaikh, Duncan Laurie. Hello build bot (Jenkins), Patrick Georgi, Duncan Laurie, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51485
to look at the new patch set (#6).
Change subject: sar: Fix semantics of `get_wifi_sar_cbfs_filename()` ......................................................................
sar: Fix semantics of `get_wifi_sar_cbfs_filename()`
Currently, if `get_wifi_sar_cbfs_filename()` returns NULL, then `get_wifi_sar_limits()` assumes that the default filename is used for CBFS SAR file. This prevents a board from supporting different models using the same firmware -- some which require SAR support and some which don't.
This change updates the logic in `get_wifi_sar_limits()` to return early if filename is not provided by the mainboard. In order to maintain the same logic as before, current mainboards are updated to return WIFI_SAR_CBFS_DEFAULT_FILENAME instead of NULL in default case.
Change-Id: I68b5bdd213767a3cd81fe41ace66540acd68e26a Signed-off-by: Furquan Shaikh furquan@google.com --- M src/include/sar.h M src/mainboard/google/dedede/variants/drawcia/variant.c M src/mainboard/google/dedede/variants/galtic/variant.c M src/mainboard/google/dedede/variants/madoo/variant.c M src/mainboard/google/dedede/variants/magolor/variant.c M src/mainboard/google/hatch/variants/dratini/variant.c M src/mainboard/google/hatch/variants/kindred/variant.c M src/mainboard/google/octopus/variants/bloog/variant.c M src/mainboard/google/octopus/variants/bobba/variant.c M src/mainboard/google/octopus/variants/casta/variant.c M src/mainboard/google/octopus/variants/fleex/variant.c M src/mainboard/google/octopus/variants/foob/variant.c M src/mainboard/google/octopus/variants/meep/variant.c M src/mainboard/google/octopus/variants/phaser/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/volteer/variants/lindar/variant.c M src/mainboard/google/zork/variants/vilboz/variant.c M src/vendorcode/google/chromeos/sar.c 18 files changed, 49 insertions(+), 82 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/51485/6