Attention is currently required from: Jason Glenesk, Paul Menzel, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52857 )
Change subject: mb/amd/majolica:Set S0i3 enabled by default
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52857/comment/99980e85_642f7681
PS2, Line 9: Set enable S0i3 for Majolica.
Why was it disabled in the first place, and what changed?
We're still adding features to the board and soc, and rounding out the level of support. Once we got s0i3 to work...
https://review.coreboot.org/c/coreboot/+/52857/comment/c2811a5d_34638a02
PS2, Line 11: BUG=178728116
BUG=b:178728116
File src/mainboard/amd/majolica/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52857/comment/0455df36_311ffe4b
PS2, Line 17: 1
"true"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I808e78f41509cb03821513b5b63cc8856c891d8c
Gerrit-Change-Number: 52857
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 04 May 2021 20:12:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment