Change in coreboot[master]: mb/intel/adlrvp: Replace if-else-if ladder with switch construct
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47054 )
Change subject: mb/intel/adlrvp: Replace if-else-if ladder with switch construct ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp/... PS2, Line 76: case ADL_P_LP4_1:
It's an old habit of mine that would give you a heuristic to catch unintended fallthroughs. […]
Our current compiler flags make GCC complain on potentially-incorrect implicit fallthroughs unless there's a comment. Since having contiguous cases fall through is commonly intentional, GCC does not warn on these.
-
Angel Pons (Code Review)