Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80002?usp=email )
Change subject: soc/amd/*/romstage: factor out FSP-M call
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
I'm marking it as +2, because it's really fine, I'm just not crazy about the name. Feel free to ignore my comment if I'm being silly.
File src/soc/amd/cezanne/romstage.c:
https://review.coreboot.org/c/coreboot/+/80002/comment/a904405b_75b71d82 :
PS2, Line 20: call
Just a nit, but I'm not crazy about the name. I'm channeling my inner Paul here.
Maybe something like one of these:
- run_fsp_m()
- fsp_m_init()
- fsp_m()
- early_silicon_init() - this could be preceded by "first_silicon_init()" and we could have mid_ late_ final_ post_enum_ etc_ come later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80002?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I30cf1bee2ec1a507dc8e61eaf44067663e2505ae
Gerrit-Change-Number: 80002
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 18 Jan 2024 22:08:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment