[XS] Change in coreboot[main]: Don't build a separate romstage by default in some cases - coreboot-gerrit

23 Mar 2024


      Attention is currently required from: Andrey Petrov, Frans Hendriks, Julius Werner, Nico Huber, Paul Menzel, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63419?usp=email )
Change subject: Don't build a separate romstage by default in some cases
......................................................................
Patch Set 56:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/63419/comment/04ee9d40_72b81eeb :
PS42, Line 1471: 	default y if VBOOT_STARTS_IN_BOOTBLOCK || BOOTBLOCK_NORMAL || ASAN_IN_ROMSTAGE
...
VBOOT alread has a select on this and maybe the others should have one too? […]
Done I guess?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4c53b6fa7a3e66415c5b1c539918a6c1cd8defa1
Gerrit-Change-Number: 63419
Gerrit-PatchSet: 56
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Erik van den Bogaert ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Maximilian Brune maximilian.brune@9elements.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Frans Hendriks fhendriks@eltan.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Sat, 23 Mar 2024 12:42:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment