Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Mathew King, Angel Pons. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51045 )
Change subject: soc/amd/cezanne: Fill out pci devices in chipset.cb ......................................................................
Patch Set 8:
(1 comment)
File src/soc/amd/cezanne/chipset.cb:
https://review.coreboot.org/c/coreboot/+/51045/comment/d7961be9_0a5ba2e0 PS6, Line 20: device pci 8.0 alias dummy_8 off end # Dummy Host Bridge
Done
i'd keep the dummy bridges on and don't give them an alias. leaving them on doesn't really hurt, but it might cause not completely expected behaviour to switch them off. function 0 is a dummy device that should probably always be on. when function 0 of a device isn't present, all other functions are also assumed to be not present. so to avoid having to renumber the functions like it is done in intel systems if function 0 isn't used, but some other function on the same device is, function 0 here is just a dummy that should be kept active and now there's no case where the other functions might need to get renumbered in order for things to work. ok, for bus c that might result in unnecessarily eating up one bus number
-
Felix Held (Code Review)