Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/53918 )
Change subject: soc/amd/picasso,common: move ALIB DPTC parameter struct to common code ......................................................................
soc/amd/picasso,common: move ALIB DPTC parameter struct to common code
Also add an alib_ prefix to avoid possible name collisions.
TEST=Timeless build for Mandolin results in identical binary.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ib0f220a4cde6da764bb8bc589b5f44ae16496bd7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/53918 Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/include/amdblocks/alib.h M src/soc/amd/picasso/root_complex.c 2 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/alib.h b/src/soc/amd/common/block/include/amdblocks/alib.h index e11b1ae..5e92924 100644 --- a/src/soc/amd/common/block/include/amdblocks/alib.h +++ b/src/soc/amd/common/block/include/amdblocks/alib.h @@ -16,6 +16,11 @@ ALIB_DPTC_SLOW_PPT_LIMIT_ID = 0x7, };
+struct alib_dptc_param { + uint8_t id; + uint32_t value; +} __packed; + #endif /* !__ACPI__ */
#endif /* AMD_COMMON_ALIB_H */ diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index c0b444f..979da3e 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -20,14 +20,9 @@
#define DPTC_TOTAL_UPDATE_PARAMS 4
-struct dptc_param { - uint8_t id; - uint32_t value; -} __packed; - struct dptc_input { uint16_t size; - struct dptc_param params[DPTC_TOTAL_UPDATE_PARAMS]; + struct alib_dptc_param params[DPTC_TOTAL_UPDATE_PARAMS]; } __packed;
#define DPTC_INPUTS(_thermctllmit, _sustained, _fast, _slow) \