build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28328 )
Change subject: mb/google/octopus: Add missing standby settings. ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 120: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_79, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* H1_SLAVE_SPI_CLK_R */ line over 80 characters
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 121: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_80, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* H1_SLAVE_SPI_CS_L_R */ line over 80 characters
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 247: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* EN_PP3300_WLAN */ line over 80 characters
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bip/gpio.c:
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 118: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_79, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* H1_SLAVE_SPI_CLK_R */ line over 80 characters
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 119: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_80, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* H1_SLAVE_SPI_CS_L_R */ line over 80 characters
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 246: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* EN_PP3300_WLAN */ line over 80 characters
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bobba/gpio.c:
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 34: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), line over 80 characters
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 49: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), line over 80 characters
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/phaser/gpio.c:
https://review.coreboot.org/#/c/28328/1/src/mainboard/google/octopus/variant... PS1, Line 36: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), line over 80 characters