Attention is currently required from: Joel Kitching, Martin Roth, Yidi Lin, Yu-Ping Wu, hsin-hsiung wang.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51409 )
Change subject: mb/google/asurada: Move PMIC and RTC initialization to romstage.
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/asurada/romstage.c:
https://review.coreboot.org/c/coreboot/+/51409/comment/8e3c5ef7_dbfddc47
PS1, Line 59: mt6359p_romstage_init();
: mt6315_romstage_init(
should we delete these unused functions?
https://review.coreboot.org/c/coreboot/+/51409/comment/e8de945b_37362943
PS1, Line 68: rtc_boot
will it be too late if we setup RTC here? (will the clocks still be the same?)
The firmware used to have timestamps (run cbmem and check) - I hope this won't break log time in coreboot?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51409
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e4c3f918639590ffc73076450235771d06aae91
Gerrit-Change-Number: 51409
Gerrit-PatchSet: 1
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Attention: Joel Kitching
kitching@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Comment-Date: Thu, 11 Mar 2021 13:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment