Attention is currently required from: Joel Kitching, Martin Roth, Yidi Lin, Yu-Ping Wu, hsin-hsiung wang.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51409 )
Change subject: mb/google/asurada: Move PMIC and RTC initialization to romstage.
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51409/comment/b5081293_ff05908a
PS1, Line 7: Move PMIC and RTC initialization to romstage.
are we fixing any real issues? if yes describe that, otherwise this should be "revise PMIC and RTC initialization"
https://review.coreboot.org/c/coreboot/+/51409/comment/f4ae8751_f25d4a2a
PS1, Line 9:
from bootblock
https://review.coreboot.org/c/coreboot/+/51409/comment/78335f28_73008d2f
PS1, Line 9: We move
Move
https://review.coreboot.org/c/coreboot/+/51409/comment/06db86f0_628fef54
PS1, Line 13: can be corrected after
: firmware update.
may need to be changed by an RW firmware update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51409
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e4c3f918639590ffc73076450235771d06aae91
Gerrit-Change-Number: 51409
Gerrit-PatchSet: 1
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Attention: Joel Kitching
kitching@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Comment-Date: Thu, 11 Mar 2021 13:33:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment