Attention is currently required from: Hung-Te Lin, Jarried Lin, Nancy Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email )
Change subject: mb/google/rauru: Configure firmware display for eDP panel
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85952/comment/692583b9_d4b9f9c7?usp... :
PS4, Line 104: mt6373_enable_vcn33_3(true);
Would `false` disable? I’d prefer an enable and disable function without an argument.
https://review.coreboot.org/c/coreboot/+/85952/comment/c7bd9cc9_4c0313f9?usp... :
PS4, Line 104: mt6373_enable_vcn33_3(true);
: mt6373_set_vcn33_3_voltage(3300000);
This API looks strange. Why does the set function not run enable, when needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85952?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036
Gerrit-Change-Number: 85952
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 11:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No