[M] Change in coreboot[main]: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper

[Naresh Solanki (Code Review)]

Attention is currently required from: Angel Pons, Felix Held, Jérémy Compostella, Maximilian Brune, Patrick Rudolph, Paul Menzel.

Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )

Change subject: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper
......................................................................

Patch Set 5:

(3 comments)

File src/soc/amd/glinda/cpu.c:

https://review.coreboot.org/c/coreboot/+/85640/comment/0d183f40_59def24c?usp... :
PS5, Line 24: uint32_t leaf = DETERMINISTIC_CACHE_PARAMETERS_CPUID_AMD;
            : 	uint8_t level = 3;
            : 
            : 	struct cpuid_result cache_info_res = cpuid_ext(leaf, level);
            : 
            : 	info->type = CPUID_CACHE_TYPE(cache_info_res);
            : 	info->level = CPUID_CACHE_LEVEL(cache_info_res);
            : 	info->num_ways = CPUID_CACHE_WAYS_OF_ASSOC(cache_info_res) + 1;
            : 	info->num_sets = CPUID_CACHE_NO_OF_SETS(cache_info_res) + 1;
            : 	info->line_size = CPUID_CACHE_COHER_LINE(cache_info_res) + 1;
            : 	info->physical_partitions = CPUID_CACHE_PHYS_LINE(cache_info_res) + 1;
            : 	info->num_cores_shared = CPUID_CACHE_SHARING_CACHE(cache_info_res) + 1;
            : 	info->fully_associative = CPUID_CACHE_FULL_ASSOC(cache_info_res);
            : 	info->size = get_cache_size(info);
> This is pretty much the same as `fill_cpu_cache_info` (excluding the call to `soc_fill_cpu_cache_inf […]

1. yes its possible to deduplicate it.

2. Multiplying uniq id with cache size might not work considering that glinda SoC has 16MB + 8MB. We want it to report total L3 cache as 24MB instead of 32.

https://review.coreboot.org/c/coreboot/+/85640/comment/a4cbdb10_ee6026c3?usp... :
PS5, Line 52: if (!info)
            : 		return false;
> This is checked by `fill_cpu_cache_info`

Acknowledged

https://review.coreboot.org/c/coreboot/+/85640/comment/1d82fb47_de5ac3b4?usp... :
PS5, Line 70: ::
> nit: drop one colon […]

Acknowledged