Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40867 )
Change subject: soc/amd/picasso/bootblock: Remove duplicate sb_reset_i2c_slaves ......................................................................
soc/amd/picasso/bootblock: Remove duplicate sb_reset_i2c_slaves
sb_reset_i2c_slaves is called in fch_pre_init.
BUG=b:153675916 TEST=Builds on trembyle
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I157e473984257d633ceb3ef9df45c71a31c5c00b --- M src/soc/amd/picasso/bootblock/bootblock.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40867/1
diff --git a/src/soc/amd/picasso/bootblock/bootblock.c b/src/soc/amd/picasso/bootblock/bootblock.c index de0cb6e..24b8f94 100644 --- a/src/soc/amd/picasso/bootblock/bootblock.c +++ b/src/soc/amd/picasso/bootblock/bootblock.c @@ -17,7 +17,6 @@
void bootblock_soc_early_init(void) { - sb_reset_i2c_slaves(); fch_pre_init(); }
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40867 )
Change subject: soc/amd/picasso/bootblock: Remove duplicate sb_reset_i2c_slaves ......................................................................
Patch Set 1: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40867 )
Change subject: soc/amd/picasso/bootblock: Remove duplicate sb_reset_i2c_slaves ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40867 )
Change subject: soc/amd/picasso/bootblock: Remove duplicate sb_reset_i2c_slaves ......................................................................
soc/amd/picasso/bootblock: Remove duplicate sb_reset_i2c_slaves
sb_reset_i2c_slaves is called in fch_pre_init.
BUG=b:153675916 TEST=Builds on trembyle
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I157e473984257d633ceb3ef9df45c71a31c5c00b Reviewed-on: https://review.coreboot.org/c/coreboot/+/40867 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/picasso/bootblock/bootblock.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/amd/picasso/bootblock/bootblock.c b/src/soc/amd/picasso/bootblock/bootblock.c index 56cdbd9..b1f43c2 100644 --- a/src/soc/amd/picasso/bootblock/bootblock.c +++ b/src/soc/amd/picasso/bootblock/bootblock.c @@ -50,7 +50,6 @@
void bootblock_soc_early_init(void) { - sb_reset_i2c_slaves(); fch_pre_init(); }